Ensure force kill timeout isn't keeping process alive

[bengourley]

👋 I don't know if you still use this module? I was checking it out in relation to something similar I'm working on and noticed what I think is a bug.

I thought I'd throw this PR up quickly – I didn't add any tests but I did run the existing ones and they apssed. I'm pretty sure the behaviour of this module would be to wait up to forceTimeout ms every time the process is killed in non-dev envs because the timeout would keep the event loop non-empty.

See unref() for more info.

[serby]

Thanks for the PR

@bengourley Hope you are well.

I'm sure this worked as expected when it was written. I've not used .unref() but since v9.7.0 it looks like that is the correct way to ensure the event loop kept running.

I'll merge and release and investigate at a later date.

[bengourley]

I'm good thanks!

unref() was added in 0.9 (not 9) so it's been around a while! I'm pretty sure I remember the processes not closing out quick enough in dev, which was why we skipped the whole thing with the NODE_ENV dev check. Cause my have been this – could be wrong though.

[serby]

I'm an idiot! I read the doc wrong.

I'll do some investigation and let you know how I get on.

[bengourley]

Having pondered this a little more, the explicit process.exit() will not care about anything on the event loop. This would only be the case if you wanted to let the process terminate "naturally", by running out of things to do. So this was all just a little bit pointless, sorry! 😌

…

On Sun, 12 Aug 2018, 10:45 Paul Serby, ***@***.***> wrote: I'm an idiot! I read the doc wrong. I'll do some investigation and let you know how I get on. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlNKzhS7rXU0_iUBzicMpwmNIyTAe_5ks5uP_kegaJpZM4V4O_J> .

[serby]

No totally pointless as I wasn't aware of .unref() so I've learnt something, thanks!

You should drop by sometime, it would be good to catch up.