Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache results of methods that request data using Http #2869

Open
jamesbt365 opened this issue May 21, 2024 · 1 comment
Open

Cache results of methods that request data using Http #2869

jamesbt365 opened this issue May 21, 2024 · 1 comment

Comments

@jamesbt365
Copy link
Contributor

A lot of methods that request data do not cache the result, leading to requesting information far more often than is actually needed. We should scrub through and try and cache as much information as possible to prevent the need to request it twice.

This is a problem on both current and next.

For example, Guild and GuildId do not cache the request of the Http request on the member method, this happens all across the library for methods that fetch data.

@sarahkittyy
Copy link

+1, I am calling GuildId::member on 15 or so users and the fact that it's not cached is making the command take like 10 seconds. I don't even know how I would manually add it to the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants