Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong placement of instances when "getMany" and "sibling types" are used #95

Closed
sergejsha opened this issue Aug 3, 2019 · 1 comment · Fixed by #96
Closed

Wrong placement of instances when "getMany" and "sibling types" are used #95

sergejsha opened this issue Aug 3, 2019 · 1 comment · Fixed by #96
Assignees
@sergejsha
Labels
bug Something isn't working
Milestone
3.3

Comments

@sergejsha
Copy link
Owner

Version: 3.3-rc5

Given

Scopes: scopeA { Bound1 } <- scopeB { Bound3 }
Types:

Dep1 -> [Bound1, Dep2]
Dep2 (w/ sibling Dep2Sibling) -> many(Dep3)`
Dep3 -> Bound3`

When

scopeB.getSingle(Dep2Sibling.class)
scopeB.getSingle(Dep1.class)

Expected

scopeA { Bound1 }
scopeB { Dep1, Dep2, Dep2Sibling, Dep3, Bound3 }

Actual

scopeA { Bound1, Dep1 }
scopeB { Dep2, Dep2Sibling, Dep3, Bound3 }
@sergejsha sergejsha self-assigned this Aug 3, 2019
@sergejsha sergejsha added the bug Something isn't working label Aug 3, 2019
@sergejsha sergejsha added this to the 3.3 milestone Aug 3, 2019
@sergejsha sergejsha mentioned this issue Aug 4, 2019
Merged
@sergejsha
Copy link
Owner Author

Fix is available in 3.3-rc6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergejsha sergejsha

Labels
bug Something isn't working
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Issue fix and unit test sergejsha/magnet
1 participant
@sergejsha