Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styled-normalize@8.0.3 types are incompatible with styled-components@<4 #9

Closed
elektronik2k5 opened this issue Nov 6, 2018 · 7 comments
Assignees
Labels

Comments

@elektronik2k5
Copy link

Hello and thanks for creating this package! πŸ™‡β€β™‚οΈ

I tried upgrading styled-normalize from 8.0.2 to 8.0.3 with the latest styled-components@3. Because

import { InterpolationValue, GlobalStyleClass, DefaultTheme } from 'styled-components'
imports styled-components@4's GlobalStyleClass, DefaultTheme, which don't exist in v3 - TS compilation fails.

I don't really see a way around this, except for fixing peerDependencies to exclude styled-components@4 in styled-normalize@>=8.0.3.

I think this also warrants a new major version and unpublishing of styled-normalize@8.0.3, since it's broken for TS users.

@sergeysova
Copy link
Owner

@elektronik2k5 Thank you.
styled-normalize not follows semver. Version x.y matches normalize.css https://github.com/sergeysova/styled-normalize/releases/tag/v8.0.0.

I'm going to release patch version with the fix (8.0.4)

@sergeysova
Copy link
Owner

sergeysova commented Nov 13, 2018

@elektronik2k5 Please, use https://github.com/sergeysova/styled-normalize/releases/tag/v8.0.4

But now, styled-normalize only supports styled-components@4

@sergeysova
Copy link
Owner

@elektronik2k5 If you need styled-components@v3 you can install prev version:

npm install styled-normalize@prev

https://github.com/sergeysova/styled-normalize/releases/tag/v8.0.4-prev

@sergeysova
Copy link
Owner

Also fixed in #10

@elektronik2k5
Copy link
Author

Thanks @sergeysova ! I suggest we add this to README.md, since right now it isn't clear what should styled-components@3 users do. Would you like a PR for that?

@sergeysova
Copy link
Owner

If you have some time, please, make PR.

@elektronik2k5
Copy link
Author

I see it's documented already. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants