Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the version a "const" ? #5

Closed
yairEO opened this issue Sep 8, 2018 · 5 comments
Closed

Why is the version a "const" ? #5

yairEO opened this issue Sep 8, 2018 · 5 comments
Assignees
@sergeysova
Labels
question

Comments

@yairEO
Copy link

yairEO commented Sep 8, 2018

Never seen that before.
Any reason why it's not written as a comment at the top of the file?
@sergeysova
Copy link
Owner

One app requires, to show the version of normalize.css used.
Also, some developers check the version of normalize in their code.

@yairEO
Copy link
Author

yairEO commented Sep 9, 2018

so why aren't any of the million other NPM packages doing it?
I just don't see any reason at all. if anyone wants to actively check the version in their code they can parse the package.json file, no need to pollute each script on the plant with a variable specifying its version.

@sergeysova
Copy link
Owner

You're right. But in previous releases version of styled-normalize was differed from the version of normalize.css

@sergeysova
Copy link
Owner

I'm going to remove version export in v8.0.4 (#9)

@sergeysova sergeysova self-assigned this Nov 13, 2018
sergeysova added a commit that referenced this issue Nov 13, 2018
@sergeysova
fix: ts types. remove version. update deps #9 #5
ca4521c
@sergeysova
Copy link
Owner

https://github.com/sergeysova/styled-normalize/releases/tag/v8.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeysova sergeysova

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yairEO @sergeysova