fix(socials): change linkedin's href value #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try to use linkedin without www in front of it, it throws `Hmm. We’re having trouble finding that site.` on Firefox.
sergiokopplin
approved these changes
Apr 19, 2020
KPdir
added a commit
to KPdir/kpdir.github.io
that referenced
this pull request
Jun 21, 2023
* Made initpost.sh executable * new light version - 1.0.0 * new light version - removing gemfile.lock new light version - adding travis file new light version - adding branch to travis file new light version - updating travis configs new light version - removing travis extra file new light version - removing extra configs new light version - readding travis file new light version - updating readme new light version - adding rakefile new light version - updating config.yml new light version - updating travis fixing travis updating gemfile removing jekyll-admin from build fixing html-proofeer adding jekyll admin jekyll-admin as group removing jekyll admin * Update README.md * Update README.md * Update README.md * Update 2016-01-23-indigo-jekyll-theme.markdown * adding https * Updates icons.html Adds lines 70-73: icon-stackoverflow * Updates social-links.html Adds lines 56-60: stackoverflow link * Update social-links.html * Updates _config.yml Adds line 41: site.stackoverflow * Line 41: fixes stackoverflow link * Adds proper stackoverflow icon * Changes title line 71 * Adds quora and reddit social links * Adds google-plus, linkedin, reddit share links * Adds comment about using share links * Fix color variable * Adding Jemoji to Blog Posts adding jemoji on blog posts list * removing unused file * updating documentation * adding jemoji style based on pr 197 * creating FAQ * Update README.md * Adding resume support to the nav bar, configurable via _config.yml * updating resume link + showing about section * showing less links on nav bar * updating screenshot * Properly formatting the word resume * Added identifier and url to disqus config * Allow config of disqus and advance links with post categories * Fix site links with local development * Update README.md * Update README.md * Update FAQ.md * Update README.md * Update 2016-01-23-indigo-jekyll-theme.markdown * Hiding of 'hidden' posts Now hides posts with the `hidden = true` option. Fixes this issue: sergiokopplin#208 P.S. By the way, thanks for creating the theme! It's really nice! * updating next branch on travis file * removing extra configs * removing unused configs based on default props from jekyll * removing npm from gitignore * fixing build errors * updating ruby v * updating ruby v * Add Last.fm social link * Update _config.yml Adding jekyll-feed to _config.yml so `feed.xml` can be generated * Fixing jemoji existing problem Removing workaround and fixing problem just adding library to gems list on `_config.yml`. * Show only posts of blog category on index without pagination * Fix social link issue (sergiokopplin#232) on mobile versions * Added support for lanyrd.com in social media list on the front page * Author's tweeter is now author specific * Update footer.html * Changed 'gems' configuration option to 'plugins' Fix to avoid warning: "Deprecation: The 'gems' configuration option has been renamed to 'plugins'. Please update your config file accordingly." * [feature] adding jekyll admin * [feature] adding jekyll-admin docs * [feature] adding more docs about jekyll-admin * Emphasize github-admin is local only * Only include google analytics script if a token is set. * Fix hidden posts appearing in blog navigation * added 404 * Change Google Analytics code position * Update Google Analytics code * Updated rvm version * Added gitlab social link and svg icon * Make gitlab optional * Fix wrong gitlab URL * fixing html-proofer errors * fix: exclude file from being generated on build (sergiokopplin#2) Fix sergiokopplin#327 * fix: exclude FAQ * fix: remove jemoji example As seen on sergiokopplin#72 , jemoji can now be generated directly with their name. This doesn't seem to be useful anymore now it is fixed. * fix: alt element defined twice inside author block This fix sergiokopplin#330 * feature: in development mode, do not compress HTML Useful for development purpose * feat: add vendor to gitignore This allow users who don't want to globally install gems to install them locally without being versionned. * build: ignore vendor bundle * feat: add font-awesome-svg icon * Explicetely set og:image meta tag * fix: smaller icons * fix: jekyll configuration see https://jekyllrb.com/docs/troubleshooting/#configuration-problems * Adds default value to `hidden` property for posts All pages with layout `post` are given a property `hidden` with default value of `false`. The value can be overwritten in the front matter of a specific post that you might want to set to hidden. Why? After PR sergiokopplin#278 no navigation links were shown unless posts had explicitly been specified as not hidden (`hidden: false`). This PR is meant to fix this issue. * Fixing invalid date in the YAML front matter error Fixing `does not have a valid date in the YAML front matter` error while building the site. More info: sergiokopplin#348. * Added info on running this site in Docker * Fixing an issue with og:image for posts Fixing an issue where all links will be shown with the site's image, instead of the image specified in the `image` field in the specific post's front matter. More info: sergiokopplin#350 * add logic to show external image for about page * exclude vendor folder found via jekyll/jekyll#5267 (comment) * Removed Google Plus references Signed-off-by: Cristiano Nunes <cfgnunes@gmail.com> * Removed Google Plus references Signed-off-by: Cristiano Nunes <cfgnunes@gmail.com> * Update compress.html from https://github.com/penibelst/jekyll-compress-html * Improving quality and performance by using online tests * Only bake icons to html if they are being used I kept the Twitter and Facebook ones unconditionally because they may also be used on the author page. I recognize that there is no `site.google-plus` variable, but this at least guarantees that this icon will never appear unless the user really wants it. * upgrade to jekyll-paginate-v2 * License heading added License heading added * feat: css improvements Thanks to @cbrueffer (cbrueffer@ae9e470) * Updating normalize.scss to the last version * Fixing variable name in sass file * Removed repeated line in the code * bugfix unrecongnized Liquid tag 'fa_svg' * 🐛 Fix Icon Size * 🐛 Fix Icon Color on Share Component * 🐛 Fix URLS with https * 🐛 Fix Travis htmlproofer runner config * Build site with GitHub actions (sergiokopplin#426) * test deploy * typo * docs: wip * test * remove DEPLOY_TOKEN, use GITHUB_TOKEN instead * use github token * try to trigger Github actions * Update README.md * Update README.md * testing * fix: removes Fontawesome (sergiokopplin#435) * fix: https on all links & removes github workflow (sergiokopplin#436) * fix: https on all links & removes github workflow * fix: removes brokwn html-proofer * fix: updates test pipeline * fix(socials): change linkedin's href value (sergiokopplin#437) If you try to use linkedin without www in front of it, it throws `Hmm. We’re having trouble finding that site.` on Firefox. * fix: site urls * Use 'post' class even if there are no tags (sergiokopplin#441) Co-authored-by: Andrés Maldonado <amaldona@etu.utc.fr> * Improve inline code CSS formatting (sergiokopplin#445) I added a grey box and centered (vertical-align: middle) the inline code. This inline formatting is similar to the GitHub line formatting. I left the multiline CSS intact. * feat: adds dark theme (sergiokopplin#484) * feat: adds dark theme * chore: updates screen shot * docs: updates * Add `rel="noopener"` to social links (sergiokopplin#481) To improve performance and prevent security vulnerabilities. * feat: dark theme as default * feat: adds dark syntax theme * feat: handles font weight on dark theme * fix: removes social link hover feature * fix: disqus username * fix: removes unused social links * fix: removes piwik * fix: removes travis ci * fix: removes config _dev * docs: removes nodejs from docs * docs: removes local config from docs * docs: removes travis from docs * Update _config.yml * feat: adds webrick gem * feat: adds fontawesome * chore: removes unused package jekyll mentions * Create CNAME * Delete CNAME * Create CNAME * Delete CNAME * fix: site title instead of site name * fix: removes jekyll-admin due to warning * fix: removes jekyll-admin due to warning * Added the missing close tags (sergiokopplin#489) * Added the missing close tags * Removed unnecessary files * fix rss feed invisible on dark mode (sergiokopplin#494) * Add option for auto theme switching depending on system preference. (sergiokopplin#497) * change post titles and remove unused * changes to project config * edit about doc * fix templates and change profile pic --------- Signed-off-by: Cristiano Nunes <cfgnunes@gmail.com> Co-authored-by: Rustam Mehmandarov <mehmandarov@gmail.com> Co-authored-by: Sérgio A. Kopplin <sergiokopplin@gmail.com> Co-authored-by: Sérgio Kopplin <kopplin@Sergios-MacBook-Pro.local> Co-authored-by: Ibar Romay <romayibar@gmail.com> Co-authored-by: Alexandru Somai <somai.alexandru@gmail.com> Co-authored-by: Brad <brad.stimpson@gmail.com> Co-authored-by: Jay Ravaliya <jayrav13@gmail.com> Co-authored-by: Eric Hartzog <AvarioDeveloper@gmail.com> Co-authored-by: James Stonehill <jamesstonehill@gmail.com> Co-authored-by: Aleksandar Gyorev <alexander.gyorev@gmail.com> Co-authored-by: Victor Hugo Bernardes de Souza <vhbsouza@gmail.com> Co-authored-by: Rafael Avelar Pacheco <rafaelpa@takenet.com.br> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Rustam Mehmandarov <mehmandarov@users.noreply.github.com> Co-authored-by: Mohak Shah <mohak@mohakshah.in> Co-authored-by: Tom Picton <tom@tompicton.co.uk> Co-authored-by: spencexyz <mccullough.spencer@gmail.com> Co-authored-by: Wei-Chung Liao <wchngliao@gmail.com> Co-authored-by: Antenore Gatta <antenore@simbiosi.org> Co-authored-by: Sylvain METAYER <contact@sylvainmetayer.fr> Co-authored-by: Oleksii Zeleniuk <alexzelenuyk@gmail.com> Co-authored-by: c-ameron <pnzreba@gmail.com> Co-authored-by: Cristiano Nunes <cfgnunes@gmail.com> Co-authored-by: Matthew Thomas <macravin@gmail.com> Co-authored-by: Chirag Arora <me@chia.ro> Co-authored-by: Kiran Sai Ram Singh <sairam.kiran05@gmail.com> Co-authored-by: Cristiano Nunes <cfgnunes@cefetmg.br> Co-authored-by: kevche <kevche@umich.edu> Co-authored-by: Taylan Dogan <doganntaylan@gmail.com> Co-authored-by: am97 <amaldona@tutanota.com> Co-authored-by: Andrés Maldonado <amaldona@etu.utc.fr> Co-authored-by: Zach Zhao <Zachzhao@outlook.com> Co-authored-by: slashformotion <45801817+slashformotion@users.noreply.github.com> Co-authored-by: Mohammad Rezania <ash.wxrz@hotmail.com> Co-authored-by: Made Indra <made.indra@protonmail.com> Co-authored-by: Ricardo Rodrigues <ricardo.e.p.rodrigues@gmail.com>
timKraeuter
added a commit
to timKraeuter/timKraeuter.github.io
that referenced
this pull request
Nov 9, 2023
* build: ignore vendor bundle * feat: add font-awesome-svg icon * fix: smaller icons * fix: jekyll configuration see https://jekyllrb.com/docs/troubleshooting/#configuration-problems * Adds default value to `hidden` property for posts All pages with layout `post` are given a property `hidden` with default value of `false`. The value can be overwritten in the front matter of a specific post that you might want to set to hidden. Why? After PR sergiokopplin#278 no navigation links were shown unless posts had explicitly been specified as not hidden (`hidden: false`). This PR is meant to fix this issue. * Fixing invalid date in the YAML front matter error Fixing `does not have a valid date in the YAML front matter` error while building the site. More info: sergiokopplin#348. * Added info on running this site in Docker * Fixing an issue with og:image for posts Fixing an issue where all links will be shown with the site's image, instead of the image specified in the `image` field in the specific post's front matter. More info: sergiokopplin#350 * add logic to show external image for about page * exclude vendor folder found via jekyll/jekyll#5267 (comment) * Improving quality and performance by using online tests * Only bake icons to html if they are being used I kept the Twitter and Facebook ones unconditionally because they may also be used on the author page. I recognize that there is no `site.google-plus` variable, but this at least guarantees that this icon will never appear unless the user really wants it. * upgrade to jekyll-paginate-v2 * feat: css improvements Thanks to @cbrueffer (cbrueffer@ae9e470) * Updating normalize.scss to the last version * Fixing variable name in sass file * bugfix unrecongnized Liquid tag 'fa_svg' * 🐛 Fix Icon Size * 🐛 Fix Icon Color on Share Component * 🐛 Fix URLS with https * 🐛 Fix Travis htmlproofer runner config * Build site with GitHub actions (sergiokopplin#426) * test deploy * typo * docs: wip * test * remove DEPLOY_TOKEN, use GITHUB_TOKEN instead * use github token * try to trigger Github actions * Update README.md * Update README.md * testing * fix: removes Fontawesome (sergiokopplin#435) * fix: https on all links & removes github workflow (sergiokopplin#436) * fix: https on all links & removes github workflow * fix: removes brokwn html-proofer * fix: updates test pipeline * fix(socials): change linkedin's href value (sergiokopplin#437) If you try to use linkedin without www in front of it, it throws `Hmm. We’re having trouble finding that site.` on Firefox. * fix: site urls * Use 'post' class even if there are no tags (sergiokopplin#441) Co-authored-by: Andrés Maldonado <amaldona@etu.utc.fr> * Improve inline code CSS formatting (sergiokopplin#445) I added a grey box and centered (vertical-align: middle) the inline code. This inline formatting is similar to the GitHub line formatting. I left the multiline CSS intact. * feat: adds dark theme (sergiokopplin#484) * feat: adds dark theme * chore: updates screen shot * docs: updates * Add `rel="noopener"` to social links (sergiokopplin#481) To improve performance and prevent security vulnerabilities. * feat: dark theme as default * feat: adds dark syntax theme * feat: handles font weight on dark theme * fix: removes social link hover feature * fix: disqus username * fix: removes unused social links * fix: removes piwik * fix: removes travis ci * fix: removes config _dev * docs: removes nodejs from docs * docs: removes local config from docs * docs: removes travis from docs * Update _config.yml * feat: adds webrick gem * feat: adds fontawesome * chore: removes unused package jekyll mentions * Create CNAME * Delete CNAME * Create CNAME * Delete CNAME * fix: site title instead of site name * fix: removes jekyll-admin due to warning * fix: removes jekyll-admin due to warning * Added the missing close tags (sergiokopplin#489) * Added the missing close tags * Removed unnecessary files * fix rss feed invisible on dark mode (sergiokopplin#494) * Add option for auto theme switching depending on system preference. (sergiokopplin#497) * fix: removes pagination due to conflict * docs: adds docker * docs: updates docs * docs: updates * Update README.md (sergiokopplin#525) * docs: updates * docs: updates * docs: updates * chore: refactor font awesome load * fix: canonical issue * fix: acessilibity issue * fix: light theme acessibiliy issue * fix: acessiliby issue * fix: accessibility issue * fix: accessibility issue * fix: perf issue * fix: perf issues * fix: removes unused code * update x-twitter icon (sergiokopplin#526) update x-twitter icon * Create CONTRIBUTION.md (sergiokopplin#528) * Update CONTRIBUTION.md file (sergiokopplin#530) * added issues url (sergiokopplin#531) * Update about.md (sergiokopplin#533) fixed the typo error --------- Co-authored-by: Sylvain METAYER <contact@sylvainmetayer.fr> Co-authored-by: Rustam Mehmandarov <mehmandarov@users.noreply.github.com> Co-authored-by: c-ameron <pnzreba@gmail.com> Co-authored-by: Cristiano Nunes <cfgnunes@gmail.com> Co-authored-by: Matthew Thomas <macravin@gmail.com> Co-authored-by: Chirag Arora <me@chia.ro> Co-authored-by: Cristiano Nunes <cfgnunes@cefetmg.br> Co-authored-by: Sérgio A. Kopplin <sergiokopplin@gmail.com> Co-authored-by: kevche <kevche@umich.edu> Co-authored-by: Taylan Dogan <doganntaylan@gmail.com> Co-authored-by: am97 <amaldona@tutanota.com> Co-authored-by: Andrés Maldonado <amaldona@etu.utc.fr> Co-authored-by: Zach Zhao <Zachzhao@outlook.com> Co-authored-by: slashformotion <45801817+slashformotion@users.noreply.github.com> Co-authored-by: Mohammad Rezania <ash.wxrz@hotmail.com> Co-authored-by: Made Indra <made.indra@protonmail.com> Co-authored-by: Ricardo Rodrigues <ricardo.e.p.rodrigues@gmail.com> Co-authored-by: Adhika P <40765693+adhika16@users.noreply.github.com> Co-authored-by: XZM27 <55028818+Xzm27@users.noreply.github.com> Co-authored-by: Himanshu Kumar Mahto <93067059+HimanshuMahto@users.noreply.github.com> Co-authored-by: KRISH SONI <67964054+krishvsoni@users.noreply.github.com> Co-authored-by: chinmay7016 <75988613+chinmay7016@users.noreply.github.com>
cpuhurtz
pushed a commit
to cpuhurtz/cpuhurtz.github.io
that referenced
this pull request
Jan 4, 2024
If you try to use linkedin without www in front of it, it throws `Hmm. We’re having trouble finding that site.` on Firefox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to use linkedin without www in front of it, it throws
Hmm. We’re having trouble finding that site.on Firefox.