Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamps in filepath are invalid #57

Closed
seriema opened this issue Oct 24, 2015 · 0 comments
Closed

Timestamps in filepath are invalid #57

seriema opened this issue Oct 24, 2015 · 0 comments
Labels
bug
Milestone
0.3.x

Comments

@seriema
Copy link
Owner

seriema commented Oct 24, 2015

By using the default implementation for Datetime toString in #51 it's now putting : in the filename, e.g. releasedate=1996-02-27t00:00:00.000z.get.json. Which is an invalid filename on Windows, Linux, and OSX.
@seriema seriema added the bug label Oct 24, 2015
@seriema seriema added this to the 0.3.x milestone Oct 24, 2015
@seriema seriema mentioned this issue Oct 24, 2015
Open
seriema added a commit that referenced this issue Oct 24, 2015
@seriema
fix(apimock): timestamps had an invalid format
40d8f44 
`00:00:00` isn’t a valid filename. Using `00.00.00` instead.

Fixes #57
@seriema seriema mentioned this issue Oct 24, 2015
Merged
seriema added a commit that referenced this issue Oct 25, 2015
@seriema
fix(apimock): timestamps had an invalid format
024c8de 
`00:00:00` isn’t a valid filename. Using `00.00.00` instead.

Fixes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.3.x
Development

No branches or pull requests
1 participant
@seriema