Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a date format for URL query params #50

Open
seriema opened this issue Oct 18, 2015 · 2 comments
Open

Decide on a date format for URL query params #50

seriema opened this issue Oct 18, 2015 · 2 comments
Labels

Comments

@seriema
Copy link
Owner

seriema commented Oct 18, 2015

While working on #44 I added a test case for dates, and the expected file name becomes so long. 1996-01-27 becomes the ISO string 1996-02-27t00:00:00.000z. E.g. a potential file name would be /mock_data/pokemon/releasedate=1996-02-27t00:00:00.000z.get.json.

Question 1: How short is ok? YYYY-MM-DD or YY-MM-DD? With or without time of day? How short timestamp? HH-MM-SS is enough?
Question 2: Should it be easy to override somehow? I'm thinking about scenarios in search API's or similar where the dates can change and would require multiple .json files to match. Maybe the date doesn't have a real impact on the UI design, like just outputting the date. But I can also think of scenarios where it does matter, like changing texts or colors depending on the date value.

@MartinSandstrom
Copy link
Contributor

Question 1:
I think YYYY-MM-DD and that HH-MM-SS is enough.

@seriema
Copy link
Owner Author

seriema commented Oct 24, 2015

How would you imagine the final path? /mock_data/pokemon/releasedate=1996-02-27_00.00.00.get.json?

I just realised that the : in the timestamp that's currently created by v0.3.1 isn't a valid filename. Logged as #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants