Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting the value in "using" #6

Open
rsabirov opened this issue Jul 30, 2018 · 0 comments
Open

Add support for setting the value in "using" #6

rsabirov opened this issue Jul 30, 2018 · 0 comments
Labels

Comments

@rsabirov
Copy link
Contributor

Some sink implementations using the name of sink name which is different from namespace. To support this we need to introduce value in using part of the config.

Here is example for https://github.com/saleem-mirza/serilog-sinks-azure-analytics.

app.config way of configuring:

<appSettings>
  <add key="serilog:using:AzureLogAnalytics" value="Serilog.Sinks.AzureAnalytics" />
 </appSettings>

Expected xml way of configuring:

<serilog>
  <using>
    <add key="AzureLogAnalytics" value="Serilog.Sinks.AzureAnalytics"/>
  </using>
</serilog>

Having only value should be still supported:

<serilog>
  <using>
    <add value="Serilog.Enrichers.Thread" />
    <add value="Serilog.Enrichers.Process" />
    <add value="Serilog.Sinks.Seq" />
  </using>
</serilog>
@rsabirov rsabirov added the bug label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant