refactor(taxonomy): Update after simplify taxonomy tables #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed "yarn start:containers" so that images are refetched once the tag is changed or there is a new image. Should should avoid problems when one uses a lot of preleleases of the mysql image.
kulla
added a commit
to serlo/frontend
that referenced
this pull request
Jun 12, 2024
After serlo/db-migrations#346 there is no taxonomy table / taxonomy ID for a taxonomy term => Thus I would delete the quest of it in the query so that I can delete this field in the API in serlo/api.serlo.org#1561
kulla
added a commit
to serlo/frontend
that referenced
this pull request
Jun 12, 2024
After serlo/db-migrations#346 there is no taxonomy table / taxonomy ID for a taxonomy term => Thus I would delete the quest of it in the query so that I can delete this field in the API in serlo/api.serlo.org#1561
kulla
added a commit
to serlo/frontend
that referenced
this pull request
Jun 12, 2024
After serlo/db-migrations#346 there is no taxonomy table / taxonomy ID for a taxonomy term => Thus I would delete the quest of it in the query so that I can delete this field in the API in serlo/api.serlo.org#1561
refactor(taxonomy-term): Remove taxonomyId from GraphQL
refactor(event): Update after simplification of event tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover todo:
taxonomyIdis really used => I hope we can delete it (other we need to support the oldtaxonomytable?!), see https://serlo.github.io/unused-graphql-properties/#TaxonomyTerm.taxonomyId