Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(taxonomy): Remove taxonomyId #3883

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

kulla
Copy link
Member

@kulla kulla commented Jun 12, 2024

After serlo/db-migrations#346 there is no taxonomy table / taxonomy ID for a taxonomy term => Thus I would delete the quest of it in the query so that I can delete this field in the API in serlo/api.serlo.org#1561

After serlo/db-migrations#346 there is no
taxonomy table / taxonomy ID for a taxonomy term => Thus I would delete
the quest of it in the query so that I can delete this field in the API
in serlo/api.serlo.org#1561
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jun 12, 2024 3:33pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 106.13 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 82 KB (-5 B) 188.12 KB
/___bot_or_not 95.27 KB (🟢 -26 B) 201.4 KB
/___editor_preview 483.92 KB (🟢 -105 B) 590.05 KB
/___old_comments 99.71 KB (🟢 -30 B) 205.84 KB
/authorization/roles 66.27 KB (🟢 -24 B) 172.4 KB
/biologie 157.41 KB (-5 B) 263.54 KB
/chemie 157.41 KB (-5 B) 263.54 KB
/content-only/[...slug] 74.42 KB (-5 B) 180.55 KB
/discussions 95.97 KB (🟢 -25 B) 202.1 KB
/editor 104.08 KB (🟢 -1.63 KB) 210.21 KB
/entity/create/[type]/[taxonomyId] 485.51 KB (🟢 -186 B) 591.64 KB
/entity/license/update/[id] 56.41 KB (🟢 -25 B) 162.54 KB
/entity/link/order/[id]/link 89.48 KB (🟢 -22 B) 195.61 KB
/entity/repository/add-revision/[...id] 484.75 KB (🟢 -183 B) 590.88 KB
/entity/repository/compare/[entity_id]/[revision_id] 85.86 KB (-5 B) 191.99 KB
/entity/taxonomy/update/[id] 69.01 KB (🟢 -22 B) 175.14 KB
/informatik 157.42 KB (-5 B) 263.54 KB
/lerntipps 157.42 KB (-5 B) 263.54 KB
/license/detail/[id] 57.93 KB (-5 B) 164.06 KB
/mathe 157.41 KB (-5 B) 263.54 KB
/metadata 46.35 KB (🟢 -29 B) 152.48 KB
/nachhaltigkeit 157.42 KB (-5 B) 263.55 KB
/page/create 484.77 KB (🟢 -185 B) 590.9 KB
/pages 57.73 KB (🟢 -26 B) 163.86 KB
/subscriptions/manage 113.69 KB (🟢 -24 B) 219.82 KB
/taxonomy/term/[copyOrMove]/batch/[id] 71.6 KB (🟢 -22 B) 177.73 KB
/taxonomy/term/create/[parent_id]/[id] 484.48 KB (🟢 -186 B) 590.61 KB
/taxonomy/term/sort/entities/[id] 93.31 KB (🟢 -22 B) 199.44 KB
/taxonomy/term/update/[id] 484.4 KB (🟢 -186 B) 590.53 KB
/user/notifications 133.15 KB (🟢 -28 B) 239.28 KB
/user/profile/[username] 175.94 KB (🟢 -29 B) 282.07 KB
/user/settings 483.52 KB (🟢 -187 B) 589.65 KB
/uuid/recycle-bin 85.97 KB (🟢 -24 B) 192.1 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho merged commit b00eb03 into meine-mathe-skills Jun 12, 2024
7 checks passed
@elbotho elbotho deleted the ONM12-kulla-2024-06-12-15-28 branch June 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants