-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/boulder #87
Merged
Merged
Feat/boulder #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
force-pushed
the
feat/boulder-config
branch
from
November 28, 2023 17:42
1fcd868
to
d5eb22a
Compare
tarkah
force-pushed
the
feat/boulder-config
branch
from
November 28, 2023 19:26
d5eb22a
to
9890705
Compare
tarkah
force-pushed
the
feat/boulder-config
branch
from
November 30, 2023 22:49
5e79f8c
to
e4e8cdc
Compare
tarkah
force-pushed
the
feat/boulder-config
branch
from
December 1, 2023 17:18
a3e9c1d
to
4bead2b
Compare
By ensuring threads are cleaned up before entering (clone) container
So we know workdir upfront when setting macros
And big refactor to reduce async footprint. This ensures when we enter container to clean the root, no async runtime lives. Async runtime has very short lifecycle now in the builder setup method, which is really only needed for network IO (download upstreams & moss packages)
Would you mind adding support for the |
As discussed on Matrix this needs merging asafp to ensure we have a baseline to operate against. |
ikeycode
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.