Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in each step of the analyze methods #24

Closed
sertansenturk opened this issue Mar 24, 2016 · 0 comments
Closed

Handle errors in each step of the analyze methods #24

sertansenturk opened this issue Mar 24, 2016 · 0 comments

Comments

@sertansenturk
Copy link
Owner

One of the methods in the analyze methods can fail due to lack of information (e.g. get_stable_notes fails if the makam of the recording is not known) or there is simply a bug.

Right now, such as case would fail all the analyze method. Nevertheless we would like to keep all the extracted information and get information on why and where the algorithms have failed.

The modules call in the analyze method should return their error state, in case there is an exception. Then the analyze method should catch it and process it in the best way the user can understand.

The output dictionary in the features should not have the keys for the failed experiments. The processed exceptions should be stacked and returned along with the features output, so that the user can be informed.

For the error stack structure, it might be best to consider how Dunya workers display these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant