Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this thing work? #1

Closed
serundeputy opened this issue Apr 7, 2017 · 4 comments
Closed

Does this thing work? #1

serundeputy opened this issue Apr 7, 2017 · 4 comments

Comments

@serundeputy
Copy link
Member

@olafgrabienski
I've ported this to Backdrop, but don't know how to tell if the resulting files are correct or useful.

The only thing I've tried is:

drush potx

which results in a 1.2M file named general.pot ... Is that useful? Is that what you expect?

If not maybe you can file issues against this repo until we get it into a state that is useful.

thanks!

@olafgrabienski
Copy link
Member

olafgrabienski commented Apr 7, 2017

First impression: At the moment I couln't test the module using Drush so I had a look at the UI of the module in a Backdrop installation. On admin/config/regional/translate/extract there are options to extract from core/modules, core/themes and modules. Looks like you can't extract from the whole core directory but I guess you can do this with Drush using the option --folder (see README of the module).

@olafgrabienski
Copy link
Member

olafgrabienski commented Apr 7, 2017

We tried to get the correct files using Drush:

  • drush potx single --folder=core
  • drush potx single --folder=profiles

Core:

Profiles:

To do:

  • check if these are really the files we need (@quicksketch?)
  • if yes, build the files from release 1.6.3 the current release
  • merge the files into one
  • import it into the language server

@olafgrabienski
Copy link
Member

check if these are really the files we need

Related: #3 (Some or all JS files are not respected by potx)

@quicksketch
Copy link
Member

I'm going to go ahead and close this because, yes, it does work. 😄

Let's make new issues for individual problems. It looks like it's generating the necessary .pot files, matching what is output by the Drupal version of this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants