Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getter to event req & res object in default handler. #2381

Conversation

KensukeTakahara
Copy link
Contributor

@KensukeTakahara KensukeTakahara commented Feb 23, 2022

This fixies #2327.

The reason for this bug is the same as for #2344.
When useV2Handler: true set in serverless.yml, this problem was not solved.

I Implemented getter function in default handler.

@slsnextbot
Copy link
Collaborator

slsnextbot commented Feb 23, 2022

Handler Size Report

There are changes to handler sizes. Please review.

Base Handler Sizes (kB) (commit 07b0685)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

New Handler Sizes (kB) (commit 9e3f79f)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 674
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #2381 (9e3f79f) into master (07b0685) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2381      +/-   ##
==========================================
+ Coverage   83.60%   83.77%   +0.16%     
==========================================
  Files         102      102              
  Lines        3691     3697       +6     
  Branches     1184     1186       +2     
==========================================
+ Hits         3086     3097      +11     
+ Misses        593      588       -5     
  Partials       12       12              
Impacted Files Coverage Δ
packages/libs/core/src/handle/default.ts 97.61% <100.00%> (+11.50%) ⬆️
packages/libs/core/src/route/page.ts 78.87% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b0685...9e3f79f. Read the comment docs.

@dphang dphang merged commit 31eff47 into serverless-nextjs:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants