Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public #245

Merged
merged 11 commits into from
Nov 30, 2019
Merged

Fix public #245

merged 11 commits into from
Nov 30, 2019

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Nov 21, 2019

fixes issue 242

implementation of recursive file list from here

@barrysteyn
Copy link
Contributor

There are many ways of doing this. @danielcondemarin used klaw in the plugin, which is more elegant IMHO. I think you should chat with him and enquire how he would like it done.

@danielcondemarin
Copy link
Contributor

Thanks folks. I'm happy with the implementation as is. I've just added a test to make sure there are no regression issues introduced later.

@danielcondemarin danielcondemarin merged commit 5f93912 into serverless-nextjs:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielcondemarin danielcondemarin danielcondemarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushi30 @barrysteyn @danielcondemarin