Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set host header for s3 origin #412

Merged
merged 2 commits into from
May 23, 2020
Merged

Explicitly set host header for s3 origin #412

merged 2 commits into from
May 23, 2020

Conversation

stan-sack
Copy link
Contributor

Background

Change

  • Explicitly set the host header when forwarding requests to S3 origin

Testing

  • Tested on my own website. Confirmed the fix

@danielcondemarin
Copy link
Contributor

Thanks @stan-sack for PR'ing. I've added a test and also set the host header for dynamic HTML pages which was missing.

@danielcondemarin danielcondemarin merged commit 2f44795 into serverless-nextjs:master May 23, 2020
@danielcondemarin danielcondemarin mentioned this pull request May 24, 2020
Closed
sclaughl pushed a commit to sclaughl/serverless-next.js that referenced this pull request Jul 16, 2020
@stan-sack @sclaughl
fix(lambda-at-edge): explicitly set host header for s3 origin (server…
24b4eac 
…less-nextjs#412)
@dphang dphang mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielcondemarin danielcondemarin danielcondemarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stan-sack @danielcondemarin