Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalidation paths config and tests #814

Merged
merged 2 commits into from
Nov 22, 2020

Conversation

jvarho
Copy link
Collaborator

@jvarho jvarho commented Nov 22, 2020

This is my attempt at extending the functionality proposed in #603 to allow skipping on empty paths.

Also, added tests for the new functionality.

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #814 (750536b) into master (307760b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   80.59%   80.60%   +0.01%     
==========================================
  Files          57       57              
  Lines        1922     1923       +1     
  Branches      425      426       +1     
==========================================
+ Hits         1549     1550       +1     
  Misses        314      314              
  Partials       59       59              
Impacted Files Coverage Δ
...rless-components/nextjs-component/src/component.ts 90.66% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307760b...750536b. Read the comment docs.

@danielcondemarin
Copy link
Contributor

Looks good to me thanks! Could you update the README as well please 🙏

@jvarho
Copy link
Collaborator Author

jvarho commented Nov 22, 2020

@danielcondemarin Done ✅

Copy link
Contributor

@danielcondemarin danielcondemarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@danielcondemarin danielcondemarin merged commit 088d0c0 into serverless-nextjs:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants