-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inputs.roleArn for existing lambda role #827
Conversation
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 80.65% 80.68% +0.02%
==========================================
Files 57 57
Lines 1933 1936 +3
Branches 431 434 +3
==========================================
+ Hits 1559 1562 +3
Misses 314 314
Partials 60 60
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just ran e2e test to check regressions: https://github.com/serverless-nextjs/serverless-next.js/actions/runs/395679068, can merge after
@dbhagen Just one question regarding this, why aren't we following the same approach of the lambda name?, for constancy and giving the lambda the correct roles:
The reason I say this is because I wouldn't want to give the I've raised an issue here: #836 |
Yes, this can be improved if needed @Arditc. I.e use one role if specified directly or use specific roles per lambda if specified as a map as per syntax you show in example. |
Allows to specify ARN of existing role instead of creating a new one.