Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): handle prerender-manifest v3 locales properly #910

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Mar 2, 2021

Fixes: #907

  • Recent Next.js version has a key for each locale in the prerender manifest routes, so we don't need to build it manually anymore. Only if version <= 2 will it do so.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #910 (bbf21c4) into master (83c8c6d) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   81.31%   81.28%   -0.03%     
==========================================
  Files          68       68              
  Lines        2488     2490       +2     
  Branches      591      592       +1     
==========================================
+ Hits         2023     2024       +1     
- Misses        398      399       +1     
  Partials       67       67              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 89.93% <66.66%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab68a3e...2211dfa. Read the comment docs.

@dphang dphang merged commit 5200d74 into master Mar 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-locales-manifest-v3 branch March 2, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access denied after deploy using versions since locale data copying
1 participant