Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): fix locale rewrites, enable rewrite tests for lo… #916

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Mar 3, 2021

…cale app

  • Pass matched parameters in rewrite to the new page correctly

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #916 (84aa6b0) into master (4361c73) will increase coverage by 0.04%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
+ Coverage   81.28%   81.33%   +0.04%     
==========================================
  Files          68       68              
  Lines        2490     2502      +12     
  Branches      592      596       +4     
==========================================
+ Hits         2024     2035      +11     
- Misses        399      400       +1     
  Partials       67       67              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/api-handler.ts 85.48% <77.77%> (+0.48%) ⬆️
...ckages/libs/lambda-at-edge/src/routing/rewriter.ts 97.77% <90.90%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4361c73...1596b5b. Read the comment docs.

@dphang dphang merged commit 6c34aa4 into master Mar 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/enable-rewrite-tests branch March 4, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant