Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-at-edge): detect and copy next-i18next files #1472

Merged
merged 11 commits into from
Jul 31, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jul 31, 2021

Should fix issues like #1444

This allows for better next-i18next support by copying commonly required files to the default lambda. Also creates a simple framework for adding additional integrations.

@slsnextbot
Copy link
Collaborator

slsnextbot commented Jul 31, 2021

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit a5d74d2)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1226,
            "Minified": 432
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 894,
            "Minified": 354
        },
        "Regeneration Lambda": {
            "Standard": 620,
            "Minified": 220
        }
    }
}

New Handler Sizes (kB) (commit d2ac9d7)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1226,
            "Minified": 432
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 894,
            "Minified": 354
        },
        "Regeneration Lambda": {
            "Standard": 620,
            "Minified": 220
        }
    }
}

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #1472 (f8579f2) into master (a5d74d2) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
+ Coverage   84.15%   84.25%   +0.09%     
==========================================
  Files          96       98       +2     
  Lines        3371     3392      +21     
  Branches     1006     1010       +4     
==========================================
+ Hits         2837     2858      +21     
  Misses        474      474              
  Partials       60       60              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 97.11% <100.00%> (+0.02%) ⬆️
...-at-edge/src/build/third-party/integration-base.ts 100.00% <100.00%> (ø)
...mbda-at-edge/src/build/third-party/next-i18next.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d74d2...f8579f2. Read the comment docs.

dependabot bot and others added 10 commits July 31, 2021 07:49
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.954.0 to 2.955.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.954.0...v2.955.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mime-types](https://github.com/jshttp/mime-types) from 2.1.31 to 2.1.32.
- [Release notes](https://github.com/jshttp/mime-types/releases)
- [Changelog](https://github.com/jshttp/mime-types/blob/master/HISTORY.md)
- [Commits](jshttp/mime-types@2.1.31...2.1.32)

---
updated-dependencies:
- dependency-name: mime-types
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.4.3 to 16.4.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/sharp](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sharp) from 0.28.4 to 0.28.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sharp)

---
updated-dependencies:
- dependency-name: "@types/sharp"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.955.0 to 2.957.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.955.0...v2.957.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.4.4 to 16.4.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.54.0 to 2.55.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.54.0...v2.55.1)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dphang dphang merged commit 3ffc938 into master Jul 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/add-nexti18next-support branch July 31, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants