Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python base SDK] Switch to using version file #721

Merged
merged 2 commits into from
May 5, 2023
Merged

[Python base SDK] Switch to using version file #721

merged 2 commits into from
May 5, 2023

Conversation

selcukcihan
Copy link
Contributor

Description

Testing done

Unit tested

@selcukcihan
Copy link
Contributor Author

@medikoo ready for review please

medikoo
medikoo reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but what about CI detection?

Should we do it, in the next PR so it doesn't accidentally try to release new version?

@selcukcihan
Copy link
Contributor Author

Looks great, but what about CI detection?

Should we do it, in the next PR so it doesn't accidentally try to release new version?

Good point, checking it

@selcukcihan
Copy link
Contributor Author

@medikoo I've disabled auto publish of new tag, we can enable after this is merged.

@selcukcihan selcukcihan requested a review from medikoo May 5, 2023 12:25
medikoo
medikoo approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit fd6ad27 into serverless:main May 5, 2023
@selcukcihan selcukcihan mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
runtime/python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selcukcihan @medikoo