Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't remove local.settings.json in offline cleanup #267

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

tbarlow12
Copy link
Contributor

Fixes issue of removing local.settings.json in offline cleanup. There might be project sensitive information there, and it would be inconvenient for the developer if that were removed.

Resolves AB#929

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 84.817% when pulling af00070 on tabarlow/local-settings-cleanup into 8b5a7df on dev.

@mydiemho mydiemho closed this Aug 27, 2019
@mydiemho mydiemho reopened this Aug 27, 2019
@tbarlow12 tbarlow12 force-pushed the tabarlow/local-settings-cleanup branch from af00070 to 239df18 Compare August 28, 2019 14:19
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mydiemho mydiemho merged commit 9cc06b5 into dev Aug 28, 2019
@mydiemho mydiemho deleted the tabarlow/local-settings-cleanup branch August 28, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants