v08 - fix ContinueAs data field assignment #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
force-pushed
the
continueAsValidation
branch
2 times, most recently
from
f15f602
to
fb52d75
Compare
lsytj0413
reviewed
Oct 4, 2022
lsytj0413
reviewed
Oct 4, 2022
spolti
commented
Oct 4, 2022
Closed
|
relates to #70 |
spolti
force-pushed
the
continueAsValidation
branch
2 times, most recently
from
cf35772
to
c92800a
Compare
|
interesting, I requested @lsytj0413 to re-review and it removed you @ricardozanini lol |
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage ? 19.54%
=======================================
Files ? 15
Lines ? 655
Branches ? 0
=======================================
Hits ? 128
Misses ? 492
Partials ? 35
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ricardozanini
approved these changes
Oct 4, 2022
lsytj0413
reviewed
Oct 5, 2022
lsytj0413
reviewed
Oct 5, 2022
lsytj0413
reviewed
Oct 5, 2022
|
/lgtm |
spolti
force-pushed
the
continueAsValidation
branch
2 times, most recently
from
7ba8ffa
to
ac2546d
Compare
lsytj0413
reviewed
Oct 5, 2022
Signed-off-by: spolti <filippespolti@gmail.com>
spolti
force-pushed
the
continueAsValidation
branch
from
ac2546d
to
0770c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spolti filippespolti@gmail.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):