This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Enable expression complexity limits. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a stack-overflow crash in long-expressions-should-not-crash.html on newer Mesa, and apparently also on (at least older) NVIDIA drivers. This defaults to angle's default "256". Firefox seems to do 1000 for the NVIDIA bug and not cover Mesa.
|
Note that I haven't done a full wpt run on this yet, as I'm still trying to figure out how to get ./mach test-wpt to run the webgl subset. |
|
Did the test now, and it looks like it's a fix for this test and it lets me fix the test I originally meant to, without regressions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a stack-overflow crash in long-expressions-should-not-crash.html
on newer Mesa, and apparently also on (at least older) NVIDIA drivers.
This defaults to angle's default "256". Firefox seems to do 1000 for
the NVIDIA bug and not cover Mesa.