Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Fix an osx internal assertion in NSWindow - ensure the C string is null terminated. #72

Merged
merged 1 commit into from
Feb 18, 2015
Merged

Conversation

glennw
Copy link
Member

@glennw glennw commented Feb 18, 2015

No description provided.

@glennw
Copy link
Member Author

glennw commented Feb 18, 2015

r? @pcwalton or @metajack or @larsbergstrom

@SSheldon
Copy link
Contributor

I'd recommend switching to the initWithBytes:length:encoding: method, which is pretty easy to safely wrap from Rust: https://github.com/SSheldon/rust-objc/blob/e55aec485ad2b551be65ed658ae82d0997b3eb3a/foundation/string.rs#L52-61

@brendanzab
Copy link
Contributor

I'm going to r+ this, but please post a follow up PR with @SSheldon's fix.

brendanzab added a commit that referenced this pull request Feb 18, 2015
Fix an osx internal assertion in NSWindow - ensure the C string is null terminated.
@brendanzab brendanzab merged commit 7768a8f into servo:master Feb 18, 2015
@glennw glennw deleted the fix-nswindow-crash branch February 18, 2015 21:11
@glennw
Copy link
Member Author

glennw commented Feb 18, 2015

@SSheldon and @bjz Sure, thanks for the tip, I don't know cocoa very well. Opened a follow up issue here #73

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants