Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the definition of CFAllocatorContext #415

Merged
merged 1 commit into from Oct 13, 2020

Conversation

jrmuizel
Copy link
Collaborator

The function pointers can be null so should be wrapped in Option.

This struct was basically unusable before so I think we should
be fine making this change while only bumping the patch version.
I was unable to find any uses of it on github.

The function pointers can be null so should be wrapped in Option.

This struct was basically unusable before so I think we should
be fine making this change while only bumping the patch version.
I was unable to find any uses of it on github.
@jdm
Copy link
Member

jdm commented Oct 13, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit c55fd48 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit c55fd48 with merge d2ff402...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: jdm
Pushing d2ff402 to master...

@bors-servo bors-servo merged commit d2ff402 into servo:master Oct 13, 2020
@jrmuizel
Copy link
Collaborator Author

@jdm can you do a new release of core-foundation-sys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants