Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to libc 0.2 #71

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Upgrade to libc 0.2 #71

merged 1 commit into from
Nov 5, 2015

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Nov 3, 2015

Review on Reviewable

@metajack
Copy link
Contributor

metajack commented Nov 3, 2015

This PR needs a rebase.

@mbrubeck mbrubeck changed the title Specify dependency versions in Cargo.toml Upgrade to libc 0.2 Nov 3, 2015
@mbrubeck mbrubeck mentioned this pull request Nov 3, 2015
Merged
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Nov 3, 2015

Rebased and ready to merge.

@metajack
Copy link
Contributor

metajack commented Nov 4, 2015

@bors-servo r+

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@metajack
Copy link
Contributor

metajack commented Nov 5, 2015

@bors-servo r+

1 similar comment
@metajack
Copy link
Contributor

metajack commented Nov 5, 2015

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0be9256 has been approved by metajack

@bors-servo
Copy link
Contributor

⌛ Testing commit 0be9256 with merge a4a6388...

bors-servo pushed a commit that referenced this pull request Nov 5, 2015
Auto merge of #71 - mbrubeck:libc0.2, r=metajack
a4a6388 
Upgrade to libc 0.2

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/71)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit 0be9256 into servo:master Nov 5, 2015
@SimonSapin SimonSapin mentioned this pull request Nov 19, 2015
Closed
52 tasks
jdm pushed a commit that referenced this pull request Feb 1, 2018
@brendanzab
Merge pull request #71 from SSheldon/objc_lib
8cb4e61 
Replace most of base.rs with the objc crate
jdm pushed a commit that referenced this pull request Feb 1, 2018
Auto merge of #71 - pythoneer:patch-1, r=jdm
ecf21c2 
Fixed CGEventType in event.rs

changed the enum declaration from bit shifts to one without, like in the original  CGEventTypes.h

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/71)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbrubeck @metajack @bors-servo