Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent highfive from assigning PRs to PR author #96

Closed
KiChjang opened this issue Apr 23, 2016 · 4 comments
Closed

Prevent highfive from assigning PRs to PR author #96

KiChjang opened this issue Apr 23, 2016 · 4 comments

Comments

@KiChjang
Copy link
Contributor

Right now, if a collaborator opens a new PR, there is a chance that he/she will be randomly assigned to review it. We should check to make sure that the PR author isn't being selected as the reviewer for his/her own PR.

@wafflespeanut
Copy link
Contributor

wafflespeanut commented Apr 24, 2016

Right, this should be done. And, it could still be improved to cover other cases:

  • Post a warning comment if the PR author approves the PR
  • Don't assign PR authors even if comments like r? @PR-author are posted
  • Revert assignee when PR authors are assigned explicitly (looks pretty strict, but we don't usually assign the authors to their own PRs. So, it might be worth to have it)

Thoughts?

@Ms2ger
Copy link

Ms2ger commented Apr 24, 2016

It is sometimes useful to self-assign explicitly, do let's not have the bot complain.

@wafflespeanut
Copy link
Contributor

Okay, then we don't want the third one for now.

@wafflespeanut
Copy link
Contributor

wafflespeanut commented Jun 3, 2016

I'm surprised this is still happening!

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
Adding tests for `find_reviewer` and minor editing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants