Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract RcDom into its own crate with no support guarantees #386

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Jul 21, 2019

The RcDom implementation was never intended as anything more than a test-only implementation. This work extracts it into a separate crate that contains a README that lays out what sort of support and maintenance guarantees anybody choosing to rely on it can expect (read: none).

Fixes #385.

@jdm
Copy link
Member Author

jdm commented Jul 21, 2019

The first two commits are #384 and can be ignored.

@jdm
Copy link
Member Author

jdm commented Jul 21, 2019

We can choose to either publish the markup5ever_rcdom crate or not.
Benefits of publishing:

  • makes the html5ever/xml5ever upgrade easier for anybody relying on the library; they just need to add a new dependency and change a couple imports

Downsides of publishing:

  • Much easier for people to cargo-cult the dependency from other projects that depend on html5ever and be unaware of the risks associated with using it

Benefits of not publishing:

  • forces any users of html5ever to take on the maintenance of some DOM implementation, presumably by forking the existing rcdom code into their own project
  • possibly causes someone else to create the one true html5ever DOM crate

Downsides of not publishing:

  • user frustration/confusion when upgrading to new html5ever or trying to use the library for the first time
  • high chance of lots of forked copies of rcdom, making it harder for the ecosystem to deal with new security vulnerabilities that are discovered in the future

@nox
Copy link
Contributor

nox commented Jul 21, 2019

I'm in favour of just killing it and directing people to Simon's Kuchiki crate.

@jdm
Copy link
Member Author

jdm commented Oct 21, 2019

Rebased!

@nox
Copy link
Contributor

nox commented Oct 21, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 9b90752 has been approved by nox

bors-servo pushed a commit that referenced this pull request Oct 21, 2019
Extract RcDom into its own crate with no support guarantees

The RcDom implementation was never intended as anything more than a test-only implementation. This work extracts it into a separate crate that contains a README that lays out what sort of support and maintenance guarantees anybody choosing to rely on it can expect (read: none).

Fixes #385.
@bors-servo
Copy link
Contributor

⌛ Testing commit 9b90752 with merge 040a4dd...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: nox
Pushing 040a4dd to master...

@bors-servo bors-servo merged commit 9b90752 into master Oct 21, 2019
@nox nox deleted the private-rcdom branch October 21, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract RcDom out of markup5ever
3 participants