-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a feature flag to build from source #439
Comments
Currently I'm testing linking existing static libraries and including generated rust files. It seems working so far. |
Great stuff, we would probably need two variants one with debug-mozjs feature and one without. Although we could just make release version and if debug-mozjs feature is activated we build it from source. |
We would need to extend CI, to automagically produce prebuilds and then make tags for every commit (given that mozjs is not versioned), although this could result a lot of tags. |
I guess one release version (with
Maybe we can produce prebuilds on version release. It's also a good improvement for servo since it's still using git dependency I believe. prebuilds per version release seems pretty reasonable and should be more stable for users. |
Thank you for all hard work. I will update companion PR later today. |
This is an feature request starting from zulip: https://servo.zulipchat.com/#narrow/stream/263398-general/topic/Spidermonkey.20dylib.20in.20mozjs/near/406266292
Basically, I hope we can offer a feature flag to toggle building mozjs's spidermonkey from source.
Because 99% of people always stuck on building mozjs when they want to try servo.
It would be awesome if beginners can turn the flag off and download mozjs's spidermonkey binary without compiling and bindgen.
rusty_v8 already has mechanism to do so.
The text was updated successfully, but these errors were encountered: