Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try_compile does not respect TARGET_CFLAGS #472

Closed
jschwe opened this issue Jul 4, 2024 · 1 comment
Closed

try_compile does not respect TARGET_CFLAGS #472

jschwe opened this issue Jul 4, 2024 · 1 comment

Comments

@jschwe
Copy link
Contributor

jschwe commented Jul 4, 2024

While trying to cross-compile servo on a windows host, I noticed that the mozjs try_compile configure checks don't pass any flags from TARGET_CFLAGS or TARGET_CXXFLAGS, which in my case contain the sysroot. With the sysroot flag missing one of the try_compile checks fails, since it can't find a header file (features.h). I'm not sure why I don't experience this on my Linux machine - perhaps the compiler falls back to the host sysroot (which would also be wrong).

@jschwe jschwe changed the title try_compile does not pass TARGET_CFLAGS try_compile does not respect TARGET_CFLAGS Jul 4, 2024
@jschwe
Copy link
Contributor Author

jschwe commented Jul 24, 2024

Closing this issue. It seems that replacing backslashes with forward slashes (see #478) also causes all try_compile invocations to succeed again.

@jschwe jschwe closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant