Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples to Url methods #309

Closed
brson opened this issue May 4, 2017 · 4 comments
Closed

Add examples to Url methods #309

brson opened this issue May 4, 2017 · 4 comments

Comments

@brson
Copy link
Contributor

brson commented May 4, 2017

These are missing examples: Url::options, query, query_pairs, fragment, set_fragment, set_query, set_path, path_segments, set_ip_host, set_password, set_username.
@brson brson added easy labels May 4, 2017
@brson brson mentioned this issue May 4, 2017
Closed
19 tasks
@ghost ghost mentioned this issue May 6, 2017
Closed
@marti1125
Copy link

Hello @brson I would like to contribute with this =D

@dtolnay
Copy link
Contributor

dtolnay commented May 12, 2017

@marti1125 there are some examples already written in #326. That PR also made some formatting changes that should have been done separately. Would you be able to extract out just the examples from that PR, make any improvements you would like to make, and open a separate PR?

@marti1125
Copy link

Hello @dtolnay sure =D wow there are a lot of changes 3442f0f

@ghost ghost mentioned this issue May 14, 2017
Merged
@ghost
Copy link

ghost commented May 14, 2017 •
edited by ghost
Loading

I'm open other PR #PR340 to remove rustfmt.

bors-servo pushed a commit that referenced this issue Jun 21, 2017
Auto merge of #340 - hngnaig:master, r=SimonSapin
1807848 
Add examples Url methods #309

Fix #309

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/340)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brson @marti1125 @SimonSapin @dtolnay