googlevr: Don't eagerly enable VR #28
Conversation
the framerate is weird if you enable VR without using it
Manishearth
force-pushed
the
googlevr-init
branch
from
3ee7b3d
to
63b0c1e
Compare
|
When we start presenting we must force landscape mode (and fullscreen) |
| @@ -102,6 +108,10 @@ public void run() { | |||
| // Hide GvrLayout | |||
| FrameLayout rootLayout = (FrameLayout)mActivity.findViewById(android.R.id.content); | |||
| rootLayout.removeView(gvrLayout); | |||
|
|
|||
| AndroidCompat.setVrModeEnabled(mActivity, false); | |||
| mActivity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_USER_PORTRAIT); | |||
There was a problem hiding this comment.
What if the user was browsing in landscape before he enters VR? Should we save the last orientation before entering VR?
There was a problem hiding this comment.
ah, I'll set it to _USER instead
Manishearth
force-pushed
the
googlevr-init
branch
from
752baee
to
c2240c7
Compare
|
Done. I don't know how to properly update the AAR file (should I just do a debug build? that's what I've been using for testing), can you handle that when merging? |
|
@bors-servo r=MortimerGoro I poked into the aar, it's a release build. Built one and checked it in. |
|
Checked in an AAR update, a version bump, and instructions for generating the AAR. (I don't have merge access, so I'll need you to merge/publish this once done) |
|
Thanks @Manishearth! Yep copying that file is the way to update the AAR. You can also generate it from command line |
This causes some weird framerate issues.
This now enables VR only when necessary.
I didn't update the checked in AAR file since I'm not sure what the right way to generate it. I was able to test with a GVRService-debug.aar file. (It would be nice if the googlevr folder documented how to check in changes)
also fixes servo/servo#22318
r? @MortimerGoro