Standardize pkgrepo usage #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes our workaround to be more verbose with no-op states but more robust in the case of pkrepo failures: the directory will not be cleaned until after all of the pkgrepo states complete succesfully. This also cleans up the MS TTF core fonts, and should help with servo#186.
This is part of a patch series to standardize our Salt installations.
|
r+ Thanks for cleaning this up! |
|
Uh, someday I'll learn to syntax. @bors-servo r+ |
|
📌 Commit 483d9a1 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 22, 2016
Standardize pkgrepo usage This changes our workaround to be more verbose with no-op states but more robust in the case of pkrepo failures: the directory will not be cleaned until after all of the pkgrepo states complete succesfully. This also cleans up the MS TTF core fonts, and should help with #186. Note that it appears the Vagrant `ubuntu/trusty64` image that we use already has the `multiverse` repository enabled, which might be why I can't reproduce #186 inside Vagrant; it may be worth spinning up a temporary EC2 instance to test this out (probably in masterless/local mode instead of having it connect to `servo-master`). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/250) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Merged
edunham
pushed a commit
to edunham/saltfs
that referenced
this pull request
Mar 22, 2016
Landing servo#250 added salt.common to base in top.sls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our workaround to be more verbose with no-op states but
more robust in the case of pkrepo failures: the directory will not be
cleaned until after all of the pkgrepo states complete succesfully.
This also cleans up the MS TTF core fonts, and should help with #186.
Note that it appears the Vagrant
ubuntu/trusty64image that we usealready has the
multiverserepository enabled, which might be whyI can't reproduce #186 inside Vagrant; it may be worth spinning up a
temporary EC2 instance to test this out (probably in masterless/local
mode instead of having it connect to
servo-master).This change is