Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --all flag when running ./mach test-tidy #377

Merged
merged 1 commit into from
May 25, 2016

Conversation

mitchhentges
Copy link
Contributor

@mitchhentges mitchhentges commented May 19, 2016

./mach test-tidy should be --faster by default.
However, the CI server should still check everything using the --all flag.

This PR changes the CI server to use the --all flag, but shouldn't be merged until Servo's 11267 gets merged, because 11267 adds --all


This change is Reviewable

@aneeshusa
Copy link
Contributor

r=me; just waiting for servo/servo#11267 to land.

@aneeshusa
Copy link
Contributor

servo/servo#11267 has landed.
@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a41afba has been approved by aneeshusa

@bors-servo
Copy link
Contributor

⌛ Testing commit a41afba with merge 210e704...

bors-servo pushed a commit that referenced this pull request May 25, 2016
Use --all flag when running `./mach test-tidy`

[`./mach test-tidy` should be `--faster` by default](servo/servo#11217).
However, the [CI server should still check everything using the `--all` flag](servo/servo#11267 (comment)).

This PR changes the CI server to use the `--all` flag, but shouldn't be merged until Servo's [`11267`](servo/servo#11267) gets merged, because `11267` adds `--all`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/377)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants