Remove --faster flag from test-tidy, go fast by default. Fixes 11217 #11409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit 968b9f6 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo: r- |
mitchhentges
force-pushed
the
test-tidy-faster-default
branch
from
968b9f6
to
7630944
Compare
|
New code was committed to pull request. |
highfive
added
S-awaiting-review
| @@ -5,8 +5,8 @@ matrix: | |||
| include: | |||
| - sudo: false | |||
| script: | |||
| - ./mach test-tidy --self-test | |||
| - ./mach test-tidy --no-progress | |||
| - ./mach test-tidy --no-progress --self-test | |||
There was a problem hiding this comment.
Add --no-progress to match line below, and buildbot_steps
mitchhentges
force-pushed
the
test-tidy-faster-default
branch
from
7630944
to
c699748
Compare
|
New code was committed to pull request. |
mitchhentges
force-pushed
the
test-tidy-faster-default
branch
from
c699748
to
52507c8
Compare
|
New code was committed to pull request. |
|
servo/saltfs#377 landed and was deployed, so this is safe to land now. |
|
📌 Commit 52507c8 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 25, 2016
…husa Remove --faster flag from test-tidy, go fast by default. Fixes 11217 Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11217 (github issue number if applicable). Either: - [ ] There are tests for these changes OR - [X] These changes do not require tests because they just change command-line options, which aren't tested Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. This finishes #11267 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11409) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
highfive
removed
the
S-awaiting-merge
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Servo! Please replace each
[ ]by[X]when the step is complete, and replace__with appropriate data:./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsEither:
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
This finishes #11267
This change is