Add Shing Lyu as a reviewer #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me. 恭喜 @shinglyu! |
|
@bors-servo: r+ |
|
📌 Commit b0e242b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 20, 2016
Add Shing Lyu as a reviewer r? @jdm Shing has reviewed several large changes to the `etc/ci` directories in Servo and continues to expand his expertise and interest in learning to review for even more areas! cc @shinglyu <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/512) <!-- Reviewable:end -->
|
Yay! Cogratulations Shing! :) On Wed, Oct 19, 2016 at 05:06:31PM -0700, Josh Matthews wrote:
|
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b0e242b has been approved by |
|
What? Bors went crazy when I replied by email, sigh. @bors-servo: r- r=jdm |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b0e242b has been approved by |
|
☀️ Test successful - status-travis |
|
Congrats~Shing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jdm
Shing has reviewed several large changes to the
etc/cidirectories in Servo and continues to expand his expertise and interest in learning to review for even more areas!cc @shinglyu
This change is