-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=mukilan
Fix flakiness in animation tests 1. When updating the animation timeline, ensure that nodes that are animating are marked dirty, if necessary, so any style queries will force a layout flush. 2. Disable the problematic transition test suites, as they are in Gecko. These suites often fail when Servo is so overloaded that it cannot deliver frames fast enough to get more than two samples during the animation lifecycle. Fixes #28334. Fixes #26435. Fixes #21486. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #28334, #26435, #21486. <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
- Loading branch information
Showing
19 changed files
with
51 additions
and
4,359 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
216 changes: 1 addition & 215 deletions
216
tests/wpt/metadata-layout-2020/css/css-transitions/properties-value-001.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,216 +1,2 @@ | ||
[properties-value-001.html] | ||
[background-position length(pt) / values] | ||
expected: FAIL | ||
|
||
[background-position length(pt) / events] | ||
expected: FAIL | ||
|
||
[background-position length(px) / values] | ||
expected: FAIL | ||
|
||
[background-position length(cm) / events] | ||
expected: FAIL | ||
|
||
[background-position length(mm) / values] | ||
expected: FAIL | ||
|
||
[background-position length(in) / events] | ||
expected: FAIL | ||
|
||
[background-position length(em) / events] | ||
expected: FAIL | ||
|
||
[background-position length(ex) / values] | ||
expected: FAIL | ||
|
||
[background-position length(cm) / values] | ||
expected: FAIL | ||
|
||
[background-position length(ex) / events] | ||
expected: FAIL | ||
|
||
[background-position length(pc) / events] | ||
expected: FAIL | ||
|
||
[background-position length(in) / values] | ||
expected: FAIL | ||
|
||
[background-position length(pc) / values] | ||
expected: FAIL | ||
|
||
[background-position percentage(%) / values] | ||
expected: FAIL | ||
|
||
[background-position length(mm) / events] | ||
expected: FAIL | ||
|
||
[background-position length(em) / values] | ||
expected: FAIL | ||
|
||
[background-position percentage(%) / events] | ||
expected: FAIL | ||
|
||
[background-position length(px) / events] | ||
expected: FAIL | ||
|
||
[text-shadow shadow(shadow) / values] | ||
expected: FAIL | ||
|
||
[text-shadow shadow(shadow) / events] | ||
expected: FAIL | ||
|
||
[outline-color color(rgba) / values] | ||
expected: FAIL | ||
|
||
[outline-color color(rgba) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(pt) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(pt) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(pc) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(pc) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(px) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(px) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(em) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(em) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(ex) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(ex) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(mm) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(mm) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(cm) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(cm) / events] | ||
expected: FAIL | ||
|
||
[outline-offset length(in) / values] | ||
expected: FAIL | ||
|
||
[outline-offset length(in) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(pt) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(pt) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(pc) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(pc) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(px) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(px) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(em) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(em) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(ex) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(ex) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(mm) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(mm) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(cm) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(cm) / events] | ||
expected: FAIL | ||
|
||
[outline-width length(in) / values] | ||
expected: FAIL | ||
|
||
[outline-width length(in) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(pt) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(pt) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(pc) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(pc) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(px) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(px) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(em) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(em) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(ex) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(ex) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(mm) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(mm) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(cm) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(cm) / events] | ||
expected: FAIL | ||
|
||
[vertical-align length(in) / values] | ||
expected: FAIL | ||
|
||
[vertical-align length(in) / events] | ||
expected: FAIL | ||
|
||
[vertical-align percentage(%) / values] | ||
expected: FAIL | ||
|
||
[vertical-align percentage(%) / events] | ||
expected: FAIL | ||
disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1472172 |
6 changes: 1 addition & 5 deletions
6
tests/wpt/metadata-layout-2020/css/css-transitions/properties-value-002.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,2 @@ | ||
[properties-value-002.html] | ||
[vertical-align vertical(keyword) / values] | ||
expected: FAIL | ||
|
||
[vertical-align vertical(keyword) / events] | ||
expected: FAIL | ||
disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1472172 |
Oops, something went wrong.