Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failure in /css/css-transitions/properties-value-inherit-003.html #26435

Closed
jdm opened this issue May 5, 2020 · 1 comment · Fixed by #29664
Closed

Intermittent failure in /css/css-transitions/properties-value-inherit-003.html #26435

jdm opened this issue May 5, 2020 · 1 comment · Fixed by #29664
Labels
A-layout/animations I-intermittent Problem reproduces intermittently.

Comments

@jdm
Copy link
Member

jdm commented May 5, 2020 

  ▶ Unexpected subtest result in /css/css-transitions/properties-value-inherit-003.html:
  │ FAIL [expected PASS] outline-offset length-em(em) / events
  │   → assert_equals: Expected TransitionEnd events triggered on .transition expected "" but got "outline-offset:2s"
  │ 
  │ assertExpectedEventsFunc/<@http://web-platform.test:8000/css/css-transitions/support/generalParallelTest.js:207:26
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1975:25
  │ done@http://web-platform.test:8000/css/css-transitions/properties-value-inherit-003.html:134:34
  │ concludeSlice/</</<@http://web-platform.test:8000/css/css-transitions/support/runParallelAsyncHarness.js:122:59
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1975:25
  │ concludeSlice/</<@http://web-platform.test:8000/css/css-transitions/support/runParallelAsyncHarness.js:121:38
  │ concludeSlice/<@http://web-platform.test:8000/css/css-transitions/support/runParallelAsyncHarness.js:120:23
  └ concludeSlice@http://web-platform.test:8000/css/css-transitions/support/runParallelAsyncHarness.js:118:19
@jdm jdm added I-intermittent Problem reproduces intermittently. A-layout/animations labels May 5, 2020
@jdm jdm mentioned this issue May 5, 2020
Merged
@mrobinson
Copy link
Member

It looks like properties-value-inherit-00[1,2,3].html are all flaky. I think these are the last flaky animations tests (:crossed_fingers:). The issue is that we aren't ensuring that inherited properties that are transitioning don't start transitions themselves (the original change to the inherited property can cause a transition though).

This was referenced Feb 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 27, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 7, 2023
Closed
Merged
@github-actions github-actions bot mentioned this issue Mar 15, 2023
Closed
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 26, 2023
@mrobinson
Fix flakiness in animation tests
de85265 
1. When updating the animation timeline, ensure that nodes that are
   animating are marked dirty, if necessary, so any style queries will
   force an layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
   These suites often fail when Servo is so overloaded that it cannot
   deliver frames fast enough to get more than two samples during the
   animation lifecycle.

Fixes servo#28334.
Fixes servo#26435.
Fixes servo#21486.
bors-servo added a commit that referenced this issue Apr 26, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=<try>
e0fe387 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force an layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 26, 2023
@mrobinson
Fix flakiness in animation tests
3cf2c6b 
1. When updating the animation timeline, ensure that nodes that are
   animating are marked dirty, if necessary, so any style queries will
   force an layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
   These suites often fail when Servo is so overloaded that it cannot
   deliver frames fast enough to get more than two samples during the
   animation lifecycle.

Fixes servo#28334.
Fixes servo#26435.
Fixes servo#21486.
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 26, 2023
@mrobinson
Fix flakiness in animation tests
da99de1 
1. When updating the animation timeline, ensure that nodes that are
   animating are marked dirty, if necessary, so any style queries will
   force an layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
   These suites often fail when Servo is so overloaded that it cannot
   deliver frames fast enough to get more than two samples during the
   animation lifecycle.

Fixes servo#28334.
Fixes servo#26435.
Fixes servo#21486.
This was referenced Apr 26, 2023
Merged
Merged
Merged
Merged
Merged
Merged
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 28, 2023
@mrobinson
Fix flakiness in animation tests
7398a69 
1. When updating the animation timeline, ensure that nodes that are
   animating are marked dirty, if necessary, so any style queries will
   force an layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
   These suites often fail when Servo is so overloaded that it cannot
   deliver frames fast enough to get more than two samples during the
   animation lifecycle.

Fixes servo#28334.
Fixes servo#26435.
Fixes servo#21486.
bors-servo added a commit that referenced this issue Apr 28, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=<try>
47e9da8 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This was referenced Apr 28, 2023
Merged
Closed
Merged
Merged
Merged
mrobinson added a commit to mrobinson/servo that referenced this issue May 1, 2023
@mrobinson
Fix flakiness in animation tests
54fb365 
1. When updating the animation timeline, ensure that nodes that are
   animating are marked dirty, if necessary, so any style queries will
   force an layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
   These suites often fail when Servo is so overloaded that it cannot
   deliver frames fast enough to get more than two samples during the
   animation lifecycle.

Fixes servo#28334.
Fixes servo#26435.
Fixes servo#21486.
bors-servo added a commit that referenced this issue May 1, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=<try>
84a62d7 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
mrobinson added a commit to mrobinson/servo that referenced this issue May 1, 2023
@mrobinson
Fix flakiness in animation tests
71f809c 
1. When updating the animation timeline, ensure that nodes that are
   animating are marked dirty, if necessary, so any style queries will
   force an layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
   These suites often fail when Servo is so overloaded that it cannot
   deliver frames fast enough to get more than two samples during the
   animation lifecycle.

Fixes servo#28334.
Fixes servo#26435.
Fixes servo#21486.
bors-servo added a commit that referenced this issue May 1, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=<try>
e8727a4 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue May 1, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=mukilan
4e33bbc 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@github-actions github-actions bot mentioned this issue May 1, 2023
Merged
5 tasks
bors-servo added a commit that referenced this issue May 1, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=mukilan
007e45f 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue May 1, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=mukilan
9f5977b 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue May 2, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=mukilan
0082422 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@github-actions github-actions bot mentioned this issue May 2, 2023
Merged
3 tasks
bors-servo added a commit that referenced this issue May 2, 2023
@bors-servo
Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=mukilan
0a5fbd4 
Fix flakiness in animation tests

1. When updating the animation timeline, ensure that nodes that are
    animating are marked dirty, if necessary, so any style queries will
    force a layout flush.
2. Disable the problematic transition test suites, as they are in Gecko.
    These suites often fail when Servo is so overloaded that it cannot
    deliver frames fast enough to get more than two samples during the
    animation lifecycle.

Fixes #28334.
Fixes #26435.
Fixes #21486.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #28334, #26435, #21486.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/animations I-intermittent Problem reproduces intermittently.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flakiness in animation tests mrobinson/servo
2 participants
@mrobinson @jdm