Skip to content

Commit

Permalink
Auto merge of #25837 - servo:jdm-patch-40, r=Manishearth
Browse files Browse the repository at this point in the history
Remove XR canvas dirtying step.

Alan tells me that this is no longer necessary, and it causes layout operations to appear in immersive mode profiles when there should not be any.
  • Loading branch information
bors-servo committed Feb 25, 2020
2 parents 145c89a + c12a994 commit 5ff5d9a
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions components/script/dom/xrsession.rs
Expand Up @@ -5,7 +5,6 @@
use crate::dom::bindings::callback::ExceptionHandling;
use crate::dom::bindings::cell::DomRefCell;
use crate::dom::bindings::codegen::Bindings::NavigatorBinding::NavigatorBinding::NavigatorMethods;
use crate::dom::bindings::codegen::Bindings::WebGLRenderingContextBinding::WebGLRenderingContextMethods;
use crate::dom::bindings::codegen::Bindings::WindowBinding::WindowBinding::WindowMethods;
use crate::dom::bindings::codegen::Bindings::XRReferenceSpaceBinding::XRReferenceSpaceType;
use crate::dom::bindings::codegen::Bindings::XRRenderStateBinding::XRRenderStateInit;
Expand All @@ -16,7 +15,6 @@ use crate::dom::bindings::codegen::Bindings::XRSessionBinding::XRFrameRequestCal
use crate::dom::bindings::codegen::Bindings::XRSessionBinding::XRSessionMethods;
use crate::dom::bindings::codegen::Bindings::XRSessionBinding::XRVisibilityState;
use crate::dom::bindings::codegen::Bindings::XRSystemBinding::XRSessionMode;
use crate::dom::bindings::codegen::Bindings::XRWebGLLayerBinding::XRWebGLLayerMethods;
use crate::dom::bindings::error::{Error, ErrorResult};
use crate::dom::bindings::inheritance::Castable;
use crate::dom::bindings::refcounted::Trusted;
Expand All @@ -25,8 +23,6 @@ use crate::dom::bindings::root::{Dom, DomRoot, MutDom, MutNullableDom};
use crate::dom::event::Event;
use crate::dom::eventtarget::EventTarget;
use crate::dom::globalscope::GlobalScope;
use crate::dom::node::Node;
use crate::dom::node::NodeDamage;
use crate::dom::performance::reduce_timing_resolution;
use crate::dom::promise::Promise;
use crate::dom::xrframe::XRFrame;
Expand Down Expand Up @@ -412,14 +408,6 @@ impl XRSession {
"WEBXR PROFILING [raf execute]:\t{}ms",
(time::precise_time_ns() - raf_start) as f64 / 1_000_000.
);

// If the canvas element is attached to the DOM, it is now dirty,
// and we need to trigger a reflow.
base_layer
.Context()
.Canvas()
.upcast::<Node>()
.dirty(NodeDamage::OtherNodeDamage);
}

fn update_inline_projection_matrix(&self) {
Expand Down

0 comments on commit 5ff5d9a

Please sign in to comment.