Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XR canvas dirtying step. #25837

Merged
merged 2 commits into from Mar 10, 2020
Merged

Remove XR canvas dirtying step. #25837

merged 2 commits into from Mar 10, 2020

Conversation

@jdm
Copy link
Member

jdm commented Feb 24, 2020

Alan tells me that this is no longer necessary, and it causes layout operations to appear in immersive mode profiles when there should not be any.
@highfive
Copy link

highfive commented Feb 24, 2020

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Feb 24, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Feb 24, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Feb 24, 2020
@Manishearth
Copy link
Member

Manishearth commented Feb 24, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2020

📌 Commit a832d72 has been approved by Manishearth
@jdm
Copy link
Member Author

jdm commented Feb 24, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2020

📌 Commit c12a994 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2020

⌛ Testing commit c12a994 with merge 5ff5d9a...
bors-servo added a commit that referenced this pull request Feb 25, 2020
@bors-servo
Auto merge of #25837 - servo:jdm-patch-40, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5ff5d9a 
Remove XR canvas dirtying step.

Alan tells me that this is no longer necessary, and it causes layout operations to appear in immersive mode profiles when there should not be any.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Feb 25, 2020 

  ▶ ERROR [expected OK] /webxr/xrSession_requestAnimationFrame_getViewerPose.https.html
  └   → Timeout while running cleanup for test named "XRFrame getViewerPose updates on the next frame for immersive sessions".
  ▶ ERROR [expected OK] /webxr/xrSession_viewer_referenceSpace.https.html
  └   → Timeout while running cleanup for test named "Identity reference space provides correct poses for immersive sessions".
@Manishearth
Copy link
Member

Manishearth commented Feb 25, 2020

If it failed during cleanup that means end() isn't working for some reason.
This was referenced Mar 3, 2020
Merged
Merged
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

I can reproduce those timeouts when running the tests with --headless. When there's a window showing, the tests pass as expected.
@jdm jdm mentioned this pull request Mar 6, 2020
Merged
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

With the change in servo/webxr#135 the test passes for me.
bors-servo added a commit to servo/webxr that referenced this pull request Mar 6, 2020
@bors-servo
Auto merge of #135 - jdm:headless-main-thread, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bf3d92b 
Run headless device on its own thread.

We really want to stop using the main thread code path as much as possible, and it avoids timeouts in servo/servo#25837 when the main thread blocks in other parts of the pipeline and never ends up processing the pending XR events.
@jdm jdm mentioned this pull request Mar 6, 2020
Closed
jdm added 2 commits Feb 24, 2020
@jdm
Remove XR canvas dirtying step.
085e17b
@jdm
Remove unused imports.
Loading status checks…
aa060df
@jdm jdm force-pushed the jdm-patch-40 branch from c12a994 to aa060df Mar 10, 2020
@jdm
Copy link
Member Author

jdm commented Mar 10, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

📌 Commit aa060df has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

⌛ Testing commit aa060df with merge c915668...
bors-servo added a commit that referenced this pull request Mar 10, 2020
@bors-servo
Auto merge of #25837 - servo:jdm-patch-40, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c915668 
Remove XR canvas dirtying step.

Alan tells me that this is no longer necessary, and it causes layout operations to appear in immersive mode profiles when there should not be any.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 10, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

⌛ Testing commit aa060df with merge 7010178...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 7010178 to master...
@bors-servo bors-servo merged commit 7010178 into master Mar 10, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-40 branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-blocked-on-external
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @Manishearth @bors-servo @nox
You can’t perform that action at this time.