Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XR canvas dirtying step. #25837

Merged
merged 2 commits into from Mar 10, 2020
Merged

Remove XR canvas dirtying step. #25837

merged 2 commits into from Mar 10, 2020

Conversation

jdm
Copy link
Member

@jdm jdm commented Feb 24, 2020

Alan tells me that this is no longer necessary, and it causes layout operations to appear in immersive mode profiles when there should not be any.

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 24, 2020
@jdm
Copy link
Member Author

jdm commented Feb 24, 2020

r? @Manishearth

@highfive highfive assigned Manishearth and unassigned nox Feb 24, 2020
@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a832d72 has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 24, 2020
@jdm
Copy link
Member Author

jdm commented Feb 24, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

📌 Commit c12a994 has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 24, 2020
@bors-servo
Copy link
Contributor

⌛ Testing commit c12a994 with merge 5ff5d9a...

bors-servo pushed a commit that referenced this pull request Feb 25, 2020
Auto merge of #25837 - servo:jdm-patch-40, r=Manishearth
5ff5d9a 
Remove XR canvas dirtying step.

Alan tells me that this is no longer necessary, and it causes layout operations to appear in immersive mode profiles when there should not be any.
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 25, 2020
@jdm
Copy link
Member Author

jdm commented Feb 25, 2020 

  ▶ ERROR [expected OK] /webxr/xrSession_requestAnimationFrame_getViewerPose.https.html
  └   → Timeout while running cleanup for test named "XRFrame getViewerPose updates on the next frame for immersive sessions".
  ▶ ERROR [expected OK] /webxr/xrSession_viewer_referenceSpace.https.html
  └   → Timeout while running cleanup for test named "Identity reference space provides correct poses for immersive sessions".

@Manishearth
Copy link
Member

If it failed during cleanup that means end() isn't working for some reason.

This was referenced Mar 3, 2020
Merged
Merged
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

I can reproduce those timeouts when running the tests with --headless. When there's a window showing, the tests pass as expected.

@jdm jdm mentioned this pull request Mar 6, 2020
Merged
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

With the change in servo/webxr#135 the test passes for me.

@jdm jdm added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Mar 6, 2020
bors-servo pushed a commit to servo/webxr that referenced this pull request Mar 6, 2020
Auto merge of #135 - jdm:headless-main-thread, r=Manishearth
bf3d92b 
Run headless device on its own thread.

We really want to stop using the main thread code path as much as possible, and it avoids timeouts in servo/servo#25837 when the main thread blocks in other parts of the pipeline and never ends up processing the pending XR events.
@jdm jdm mentioned this pull request Mar 6, 2020
Closed
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 10, 2020
@jdm
Copy link
Member Author

jdm commented Mar 10, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

📌 Commit aa060df has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 10, 2020
@bors-servo
Copy link
Contributor

⌛ Testing commit aa060df with merge c915668...

bors-servo pushed a commit that referenced this pull request Mar 10, 2020
Auto merge of #25837 - servo:jdm-patch-40, r=Manishearth
c915668 
Remove XR canvas dirtying step.

Alan tells me that this is no longer necessary, and it causes layout operations to appear in immersive mode profiles when there should not be any.
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 10, 2020
@jdm
Copy link
Member Author

jdm commented Mar 10, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit aa060df with merge 7010178...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 10, 2020
@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 7010178 to master...

@bors-servo bors-servo merged commit 7010178 into master Mar 10, 2020
@bors-servo bors-servo deleted the jdm-patch-40 branch March 10, 2020 02:44
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @highfive @Manishearth @bors-servo @nox