Skip to content

Commit

Permalink
Auto merge of #12617 - mskrzypkows:expose_interfaces, r=Ms2ger
Browse files Browse the repository at this point in the history
Partial fix for #12415: expose interfaces of some HTML Elements

<!-- Please describe your changes on the following line: -->
Fix for interfaces:
HTMLHeadingElement.webidl
HTMLHRElement.webidl
HTMLHtmlElement.webidl
HTMLHyperlinkElementUtils.webidl
HTMLIFrameElement.webidl
HTMLImageElement.webidl
HTMLInputElement.webidl
HTMLLabelElement.webidl
HTMLLegendElement.webidl
HTMLLIElement.webidl

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12415

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12617)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Jul 28, 2016
2 parents 3401361 + 9fa6d50 commit 90243de
Show file tree
Hide file tree
Showing 12 changed files with 2 additions and 25 deletions.
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLHRElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmlhrelement
[Exposed=(Window,Worker)]
interface HTMLHRElement : HTMLElement {
// also has obsolete members
};
Expand Down
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLHeadingElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmlheadingelement
[Exposed=(Window,Worker)]
interface HTMLHeadingElement : HTMLElement {
// also has obsolete members
};
Expand Down
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLHtmlElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmlhtmlelement
[Exposed=(Window,Worker)]
interface HTMLHtmlElement : HTMLElement {
// also has obsolete members
};
Expand Down
Expand Up @@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmlhyperlinkelementutils
[NoInterfaceObject, Exposed=(Window,Worker)]
[NoInterfaceObject]
interface HTMLHyperlinkElementUtils {
// stringifier attribute USVString href;
attribute USVString href;
Expand Down
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLIFrameElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmliframeelement
[Exposed=(Window,Worker)]
interface HTMLIFrameElement : HTMLElement {
attribute DOMString src;
// attribute DOMString srcdoc;
Expand Down
2 changes: 1 addition & 1 deletion components/script/dom/webidls/HTMLImageElement.webidl
Expand Up @@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmlimageelement
[NamedConstructor=Image(optional unsigned long width, optional unsigned long height), Exposed=(Window,Worker)]
[NamedConstructor=Image(optional unsigned long width, optional unsigned long height)]
interface HTMLImageElement : HTMLElement {
attribute DOMString alt;
attribute DOMString src;
Expand Down
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLInputElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmlinputelement
[Exposed=(Window,Worker)]
interface HTMLInputElement : HTMLElement {
attribute DOMString accept;
attribute DOMString alt;
Expand Down
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLLIElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmllielement
[Exposed=(Window,Worker)]
interface HTMLLIElement : HTMLElement {
// attribute long value;

Expand Down
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLLabelElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmllabelelement
[Exposed=(Window,Worker)]
interface HTMLLabelElement : HTMLElement {
readonly attribute HTMLFormElement? form;
attribute DOMString htmlFor;
Expand Down
1 change: 0 additions & 1 deletion components/script/dom/webidls/HTMLLegendElement.webidl
Expand Up @@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

// https://html.spec.whatwg.org/multipage/#htmllegendelement
[Exposed=(Window,Worker)]
interface HTMLLegendElement : HTMLElement {
readonly attribute HTMLFormElement? form;

Expand Down

This file was deleted.

10 changes: 0 additions & 10 deletions tests/wpt/mozilla/tests/mozilla/interfaces.worker.js
Expand Up @@ -52,15 +52,6 @@ test_interfaces([
"HTMLFormControlsCollection",
"HTMLFormElement",
"HTMLHeadElement",
"HTMLHeadingElement",
"HTMLHRElement",
"HTMLHtmlElement",
"HTMLIFrameElement",
"HTMLImageElement",
"HTMLInputElement",
"HTMLLabelElement",
"HTMLLegendElement",
"HTMLLIElement",
"HTMLLinkElement",
"HTMLMapElement",
"HTMLMediaElement",
Expand All @@ -74,7 +65,6 @@ test_interfaces([
"HTMLOutputElement",
"HTMLScriptElement",
"ImageData",
"Image",
"KeyboardEvent",
"Location",
"MediaError",
Expand Down

0 comments on commit 90243de

Please sign in to comment.