Auto merge of #9064 - nox:them-attr-names, r=Manishearth

Implement Element.getAttributeNames

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9064)
<!-- Reviewable:end -->

components/script/dom/element.rs

@@ -1228,6 +1228,11 @@ impl ElementMethods for Element {
         self.attr_list.or_init(|| NamedNodeMap::new(&window_from_node(self), self))
     }
 
+    // https://dom.spec.whatwg.org/#dom-element-getattributenames
+    fn GetAttributeNames(&self) -> Vec<DOMString> {
+        self.attrs.borrow().iter().map(|attr| attr.Name()).collect()
+    }
+
     // https://dom.spec.whatwg.org/#dom-element-getattribute
     fn GetAttribute(&self, name: DOMString) -> Option<DOMString> {
         self.GetAttributeNode(name)

components/script/dom/webidls/Element.webidl

@@ -34,6 +34,8 @@ interface Element : Node {
   [SameObject]
   readonly attribute NamedNodeMap attributes;
   [Pure]
+  sequence<DOMString> getAttributeNames();
+  [Pure]
   DOMString? getAttribute(DOMString name);
   [Pure]
   DOMString? getAttributeNS(DOMString? namespace, DOMString localName);

tests/wpt/metadata/dom/interfaces.html.ini

@@ -120,19 +120,19 @@
   [Element interface: element must inherit property "hasAttributes" with the proper type (7)]
     expected: FAIL
 
-  [Element interface: element must inherit property "removeAttributeNode" with the proper type (21)]
+  [Element interface: element must inherit property "removeAttributeNode" with the proper type (22)]
     expected: FAIL
 
   [Element interface: calling removeAttributeNode(Attr) on element with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Element interface: element must inherit property "query" with the proper type (33)]
+  [Element interface: element must inherit property "query" with the proper type (34)]
     expected: FAIL
 
   [Element interface: calling query(DOMString) on element with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Element interface: element must inherit property "queryAll" with the proper type (34)]
+  [Element interface: element must inherit property "queryAll" with the proper type (35)]
     expected: FAIL
 
   [Element interface: calling queryAll(DOMString) on element with too few arguments must throw TypeError]

tests/wpt/metadata/dom/nodes/attributes.html.ini

@@ -3,9 +3,6 @@
   [Basic functionality of removeAttributeNode]
     expected: FAIL
 
-  [getAttributeNames tests]
-    expected: FAIL
-
   [Own property names should only include all-lowercase qualified names for an HTML element in an HTML document]
     expected: FAIL
 

tests/wpt/metadata/html/dom/interfaces.html.ini

@@ -1986,19 +1986,19 @@
   [Element interface: document.createElement("noscript") must inherit property "hasAttributes" with the proper type (7)]
     expected: FAIL
 
-  [Element interface: document.createElement("noscript") must inherit property "removeAttributeNode" with the proper type (21)]
+  [Element interface: document.createElement("noscript") must inherit property "removeAttributeNode" with the proper type (22)]
     expected: FAIL
 
   [Element interface: calling removeAttributeNode(Attr) on document.createElement("noscript") with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Element interface: document.createElement("noscript") must inherit property "query" with the proper type (33)]
+  [Element interface: document.createElement("noscript") must inherit property "query" with the proper type (34)]
     expected: FAIL
 
   [Element interface: calling query(DOMString) on document.createElement("noscript") with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Element interface: document.createElement("noscript") must inherit property "queryAll" with the proper type (34)]
+  [Element interface: document.createElement("noscript") must inherit property "queryAll" with the proper type (35)]
     expected: FAIL
 
   [Element interface: calling queryAll(DOMString) on document.createElement("noscript") with too few arguments must throw TypeError]

tests/wpt/web-platform-tests/dom/interfaces.html

@@ -287,6 +287,7 @@ <h1>DOM IDL tests</h1>
 
   boolean hasAttributes();
   [SameObject] readonly attribute NamedNodeMap attributes;
+  sequence<DOMString> getAttributeNames();
   DOMString? getAttribute(DOMString name);
   DOMString? getAttributeNS(DOMString? namespace, DOMString localName);
   void setAttribute(DOMString name, DOMString value);

tests/wpt/web-platform-tests/dom/nodes/attributes.html

@@ -585,7 +585,7 @@
 
 function getEnumerableOwnProps2(obj) {
   return Object.getOwnPropertyNames(obj).filter(
-    (name) => Object.getOwnPropertyDescriptor(obj, name).enumerable)
+    function (name) { return Object.getOwnPropertyDescriptor(obj, name).enumerable; })
 }
 
 test(function() {

tests/wpt/web-platform-tests/html/dom/interfaces.html

@@ -289,6 +289,7 @@ <h1>HTML IDL tests</h1>
 
   boolean hasAttributes();
   [SameObject] readonly attribute NamedNodeMap attributes;
+  sequence<DOMString> getAttributeNames();
   DOMString? getAttribute(DOMString name);
   DOMString? getAttributeNS(DOMString? namespace, DOMString localName);
   void setAttribute(DOMString name, DOMString value);