Skip to content

Commit

Permalink
Remove not-yet-implemented members from IDL and Rust code.
Browse files Browse the repository at this point in the history 
These stub implementations bring no value, and significantly increased
maintenance costs.

This commit also synchronizes the IDL with the HTML specification and
makes the URLs consistent.
  • Loading branch information
@Ms2ger
Ms2ger committed Jun 1, 2014
1 parent eaae994 commit a0783ae
Show file tree
Hide file tree
Showing 131 changed files with 876 additions and 5,533 deletions.
133 changes: 0 additions & 133 deletions src/components/script/dom/htmlanchorelement.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use dom::bindings::codegen::BindingDeclarations::HTMLAnchorElementBinding;
use dom::bindings::codegen::InheritTypes::HTMLAnchorElementDerived;
use dom::bindings::codegen::InheritTypes::{ElementCast, HTMLElementCast, NodeCast};
use dom::bindings::js::{JSRef, Temporary, OptionalRootable};
use dom::bindings::error::ErrorResult;
use dom::document::{Document, DocumentHelpers};
use dom::attr::AttrMethods;
use dom::element::{Element, AttributeHandlers, HTMLAnchorElementTypeId};
Expand Down Expand Up @@ -43,138 +42,6 @@ impl HTMLAnchorElement {
}

pub trait HTMLAnchorElementMethods {
fn Href(&self) -> DOMString;
fn SetHref(&self, _href: DOMString) -> ErrorResult;
fn Target(&self) -> DOMString;
fn SetTarget(&self, _target: DOMString) -> ErrorResult;
fn Download(&self) -> DOMString;
fn SetDownload(&self, _download: DOMString) -> ErrorResult;
fn Ping(&self) -> DOMString;
fn SetPing(&self, _ping: DOMString) -> ErrorResult;
fn Rel(&self) -> DOMString;
fn SetRel(&self, _rel: DOMString) -> ErrorResult;
fn Hreflang(&self) -> DOMString;
fn SetHreflang(&self, _href_lang: DOMString) -> ErrorResult;
fn Type(&self) -> DOMString;
fn SetType(&self, _type: DOMString) -> ErrorResult;
fn Text(&self) -> DOMString;
fn SetText(&self, _text: DOMString) -> ErrorResult;
fn Coords(&self) -> DOMString;
fn SetCoords(&self, _coords: DOMString) -> ErrorResult;
fn Charset(&self) -> DOMString;
fn SetCharset(&self, _charset: DOMString) -> ErrorResult;
fn Name(&self) -> DOMString;
fn SetName(&self, _name: DOMString) -> ErrorResult;
fn Rev(&self) -> DOMString;
fn SetRev(&self, _rev: DOMString) -> ErrorResult;
fn Shape(&self) -> DOMString;
fn SetShape(&self, _shape: DOMString) -> ErrorResult;
}

impl<'a> HTMLAnchorElementMethods for JSRef<'a, HTMLAnchorElement> {
fn Href(&self) -> DOMString {
"".to_owned()
}

fn SetHref(&self, _href: DOMString) -> ErrorResult {
Ok(())
}

fn Target(&self) -> DOMString {
"".to_owned()
}

fn SetTarget(&self, _target: DOMString) -> ErrorResult {
Ok(())
}

fn Download(&self) -> DOMString {
"".to_owned()
}

fn SetDownload(&self, _download: DOMString) -> ErrorResult {
Ok(())
}

fn Ping(&self) -> DOMString {
"".to_owned()
}

fn SetPing(&self, _ping: DOMString) -> ErrorResult {
Ok(())
}

fn Rel(&self) -> DOMString {
"".to_owned()
}

fn SetRel(&self, _rel: DOMString) -> ErrorResult {
Ok(())
}

fn Hreflang(&self) -> DOMString {
"".to_owned()
}

fn SetHreflang(&self, _href_lang: DOMString) -> ErrorResult {
Ok(())
}

fn Type(&self) -> DOMString {
"".to_owned()
}

fn SetType(&self, _type: DOMString) -> ErrorResult {
Ok(())
}

fn Text(&self) -> DOMString {
"".to_owned()
}

fn SetText(&self, _text: DOMString) -> ErrorResult {
Ok(())
}

fn Coords(&self) -> DOMString {
"".to_owned()
}

fn SetCoords(&self, _coords: DOMString) -> ErrorResult {
Ok(())
}

fn Charset(&self) -> DOMString {
"".to_owned()
}

fn SetCharset(&self, _charset: DOMString) -> ErrorResult {
Ok(())
}

fn Name(&self) -> DOMString {
"".to_owned()
}

fn SetName(&self, _name: DOMString) -> ErrorResult {
Ok(())
}

fn Rev(&self) -> DOMString {
"".to_owned()
}

fn SetRev(&self, _rev: DOMString) -> ErrorResult {
Ok(())
}

fn Shape(&self) -> DOMString {
"".to_owned()
}

fn SetShape(&self, _shape: DOMString) -> ErrorResult {
Ok(())
}
}

trait PrivateHTMLAnchorElementHelpers {
Expand Down
113 changes: 0 additions & 113 deletions src/components/script/dom/htmlappletelement.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use dom::bindings::codegen::BindingDeclarations::HTMLAppletElementBinding;
use dom::bindings::codegen::InheritTypes::HTMLAppletElementDerived;
use dom::bindings::js::{JSRef, Temporary};
use dom::bindings::error::ErrorResult;
use dom::document::Document;
use dom::element::HTMLAppletElementTypeId;
use dom::eventtarget::{EventTarget, NodeTargetTypeId};
Expand Down Expand Up @@ -38,116 +37,4 @@ impl HTMLAppletElement {
}

pub trait HTMLAppletElementMethods {
fn Align(&self) -> DOMString;
fn SetAlign(&self, _align: DOMString) -> ErrorResult;
fn Alt(&self) -> DOMString;
fn SetAlt(&self, _alt: DOMString) -> ErrorResult;
fn Archive(&self) -> DOMString;
fn SetArchive(&self, _archive: DOMString) -> ErrorResult;
fn Code(&self) -> DOMString;
fn SetCode(&self, _code: DOMString) -> ErrorResult;
fn CodeBase(&self) -> DOMString;
fn SetCodeBase(&self, _code_base: DOMString) -> ErrorResult;
fn Height(&self) -> DOMString;
fn SetHeight(&self, _height: DOMString) -> ErrorResult;
fn Hspace(&self) -> u32;
fn SetHspace(&self, _hspace: u32) -> ErrorResult;
fn Name(&self) -> DOMString;
fn SetName(&self, _name: DOMString) -> ErrorResult;
fn Object(&self) -> DOMString;
fn SetObject(&self, _object: DOMString) -> ErrorResult;
fn Vspace(&self) -> u32;
fn SetVspace(&self, _vspace: u32) -> ErrorResult;
fn Width(&self) -> DOMString;
fn SetWidth(&self, _width: DOMString) -> ErrorResult;
}

impl<'a> HTMLAppletElementMethods for JSRef<'a, HTMLAppletElement> {
fn Align(&self) -> DOMString {
"".to_owned()
}

fn SetAlign(&self, _align: DOMString) -> ErrorResult {
Ok(())
}

fn Alt(&self) -> DOMString {
"".to_owned()
}

fn SetAlt(&self, _alt: DOMString) -> ErrorResult {
Ok(())
}

fn Archive(&self) -> DOMString {
"".to_owned()
}

fn SetArchive(&self, _archive: DOMString) -> ErrorResult {
Ok(())
}

fn Code(&self) -> DOMString {
"".to_owned()
}

fn SetCode(&self, _code: DOMString) -> ErrorResult {
Ok(())
}

fn CodeBase(&self) -> DOMString {
"".to_owned()
}

fn SetCodeBase(&self, _code_base: DOMString) -> ErrorResult {
Ok(())
}

fn Height(&self) -> DOMString {
"".to_owned()
}

fn SetHeight(&self, _height: DOMString) -> ErrorResult {
Ok(())
}

fn Hspace(&self) -> u32 {
0
}

fn SetHspace(&self, _hspace: u32) -> ErrorResult {
Ok(())
}

fn Name(&self) -> DOMString {
"".to_owned()
}

fn SetName(&self, _name: DOMString) -> ErrorResult {
Ok(())
}

fn Object(&self) -> DOMString {
"".to_owned()
}

fn SetObject(&self, _object: DOMString) -> ErrorResult {
Ok(())
}

fn Vspace(&self) -> u32 {
0
}

fn SetVspace(&self, _vspace: u32) -> ErrorResult {
Ok(())
}

fn Width(&self) -> DOMString {
"".to_owned()
}

fn SetWidth(&self, _width: DOMString) -> ErrorResult {
Ok(())
}
}
83 changes: 0 additions & 83 deletions src/components/script/dom/htmlareaelement.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use dom::bindings::codegen::BindingDeclarations::HTMLAreaElementBinding;
use dom::bindings::codegen::InheritTypes::HTMLAreaElementDerived;
use dom::bindings::js::{JSRef, Temporary};
use dom::bindings::error::ErrorResult;
use dom::document::Document;
use dom::element::HTMLAreaElementTypeId;
use dom::eventtarget::{EventTarget, NodeTargetTypeId};
Expand Down Expand Up @@ -38,86 +37,4 @@ impl HTMLAreaElement {
}

pub trait HTMLAreaElementMethods {
fn Alt(&self) -> DOMString;
fn SetAlt(&self, _alt: DOMString) -> ErrorResult;
fn Coords(&self) -> DOMString;
fn SetCoords(&self, _coords: DOMString) -> ErrorResult;
fn Shape(&self) -> DOMString;
fn SetShape(&self, _shape: DOMString) -> ErrorResult;
fn Href(&self) -> DOMString;
fn SetHref(&self, _href: DOMString) -> ErrorResult;
fn Target(&self) -> DOMString;
fn SetTarget(&self, _target: DOMString) -> ErrorResult;
fn Download(&self) -> DOMString;
fn SetDownload(&self, _download: DOMString) -> ErrorResult;
fn Ping(&self) -> DOMString;
fn SetPing(&self, _ping: DOMString) -> ErrorResult;
fn NoHref(&self) -> bool;
fn SetNoHref(&self, _no_href: bool) -> ErrorResult;
}

impl<'a> HTMLAreaElementMethods for JSRef<'a, HTMLAreaElement> {
fn Alt(&self) -> DOMString {
"".to_owned()
}

fn SetAlt(&self, _alt: DOMString) -> ErrorResult {
Ok(())
}

fn Coords(&self) -> DOMString {
"".to_owned()
}

fn SetCoords(&self, _coords: DOMString) -> ErrorResult {
Ok(())
}

fn Shape(&self) -> DOMString {
"".to_owned()
}

fn SetShape(&self, _shape: DOMString) -> ErrorResult {
Ok(())
}

fn Href(&self) -> DOMString {
"".to_owned()
}

fn SetHref(&self, _href: DOMString) -> ErrorResult {
Ok(())
}

fn Target(&self) -> DOMString {
"".to_owned()
}

fn SetTarget(&self, _target: DOMString) -> ErrorResult {
Ok(())
}

fn Download(&self) -> DOMString {
"".to_owned()
}

fn SetDownload(&self, _download: DOMString) -> ErrorResult {
Ok(())
}

fn Ping(&self) -> DOMString {
"".to_owned()
}

fn SetPing(&self, _ping: DOMString) -> ErrorResult {
Ok(())
}

fn NoHref(&self) -> bool {
false
}

fn SetNoHref(&self, _no_href: bool) -> ErrorResult {
Ok(())
}
}

4 comments on commit a0783ae

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from jdm
at Ms2ger@a0783ae

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging Ms2ger/servo/nyi = a0783ae into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ms2ger/servo/nyi = a0783ae merged ok, testing candidate = e0aac6c

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tests failed:
failure: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1470

Please sign in to comment.