Skip to content

Commit

Permalink
Wait to dump flow tree until flow is complete
Browse files Browse the repository at this point in the history
The flow tree is currently dumped for debugging purposes early on in
the flow process, so many values are still zero. If we wait to dump it
until later, the output will more accurately reflect the real flow tree.
  • Loading branch information
mrobinson committed Oct 18, 2014
1 parent b80b18f commit e7c7990
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions components/layout/layout_task.rs
Original file line number Diff line number Diff line change
Expand Up @@ -654,9 +654,6 @@ impl LayoutTask {
if self.opts.trace_layout {
layout_debug::begin_trace(layout_root.clone());
}
if self.opts.dump_flow_tree {
layout_root.dump();
}

// Perform the primary layout passes over the flow tree to compute the locations of all
// the boxes.
Expand Down Expand Up @@ -774,6 +771,10 @@ impl LayoutTask {
layout_debug::end_trace();
}

if self.opts.dump_flow_tree {
layout_root.dump();
}

rw_data.generation += 1;

// Tell script that we're done.
Expand Down

5 comments on commit e7c7990

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from pcwalton
at mrobinson@e7c7990

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging mrobinson/servo/flow-dump = e7c7990 into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrobinson/servo/flow-dump = e7c7990 merged ok, testing candidate = 3906cec

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 3906cec

Please sign in to comment.