auto merge of #4027 : znewman01/servo/issue4010, r=Ms2ger

Fixes #4010. This is my first Servo contribution, so let me know if I missed anything!
servo · Nov 18, 2014 · efb4fe4 · efb4fe4
2 parents 929671f + 2399a14
commit efb4fe4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 376 deletions.
diff --git a/components/script/dom/domimplementation.rs b/components/script/dom/domimplementation.rs
@@ -165,4 +165,9 @@ impl<'a> DOMImplementationMethods for JSRef<'a, DOMImplementation> {
         // Step 9.
         Temporary::from_rooted(*doc)
     }
+
+    // https://dom.spec.whatwg.org/#dom-domimplementation-hasfeature
+    fn HasFeature(self, _feature: DOMString, _version: DOMString) -> bool {
+        true
+    }
 }
diff --git a/components/script/dom/webidls/DOMImplementation.webidl b/components/script/dom/webidls/DOMImplementation.webidl
@@ -12,8 +12,8 @@
  */
 
 interface DOMImplementation {
-  /*boolean hasFeature(DOMString feature,
-                     [TreatNullAs=EmptyString] DOMString version);*/
+  boolean hasFeature(DOMString feature,
+                     [TreatNullAs=EmptyString] DOMString version);
   [Throws]
   DocumentType createDocumentType(DOMString qualifiedName, DOMString publicId,
                                   DOMString systemId);

diff --git a/tests/wpt/metadata/dom/interfaces.html.ini b/tests/wpt/metadata/dom/interfaces.html.ini
@@ -240,9 +240,6 @@
   [DOMImplementation interface: operation hasFeature()]
     expected: FAIL
 
-  [DOMImplementation interface: document.implementation must inherit property "hasFeature" with the proper type (3)]
-    expected: FAIL
-
   [DocumentFragment interface: operation getElementById(DOMString)]
     expected: FAIL