Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incremental reflow of text selection changes #10347

Merged
merged 1 commit into from Apr 2, 2016
Merged

Fix incremental reflow of text selection changes #10347

merged 1 commit into from Apr 2, 2016

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Apr 1, 2016

r? @emilio or @pcwalton

CC @paulrouget: This fixes a bug in the browser.html URL bar auto-completion.

This change is Reviewable

@highfive
Copy link

highfive commented Apr 1, 2016

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/mozilla/meta/MANIFEST.json, tests/wpt/mozilla/tests/css/input_selection_incremental_ref.html, tests/wpt/mozilla/tests/css/input_selection_incremental_a.html
  • @KiChjang: components/script/dom/htmlinputelement.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 1, 2016
@pcwalton
Copy link
Contributor

pcwalton commented Apr 1, 2016

Why do we force relayout here instead of dirtying the node and doing a regular layout?

@jdm
Copy link
Member

jdm commented Apr 1, 2016

force_relayout is from an older time. All it does is call document.content_changed(self), which just calls node.dirty(), so it's equivalent.

@pcwalton
Copy link
Contributor

pcwalton commented Apr 1, 2016

Let's switch to explicit dirtying then.

@mbrubeck
Copy link
Contributor Author

mbrubeck commented Apr 1, 2016

@pcwalton:

Let's switch to explicit dirtying then.

Done.

@pcwalton
Copy link
Contributor

pcwalton commented Apr 1, 2016

Looks good, squash if you like and r=me

@paulrouget
Copy link
Contributor

This fixes a bug in the browser.html URL bar auto-completion.

What bug?

@mbrubeck
Fix incremental reflow of text selection changes
776aae6 
Also replace force_relayout methods with direct Node::dirty calls, for
clarity.
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Apr 2, 2016

@bors-servo r=pcwalton

@paulrouget:

This fixes a bug in the browser.html URL bar auto-completion.

What bug?

When the URL is auto-completed, the auto-inserted part is selected, but (sometimes?) Servo does not highlight the selection right away.

@bors-servo
Copy link
Contributor

📌 Commit 776aae6 has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 2, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 776aae6 with merge abe3c62...

bors-servo pushed a commit that referenced this pull request Apr 2, 2016
Auto merge of #10347 - mbrubeck:incremental-selection, r=pcwalton
abe3c62 
Fix incremental reflow of text selection changes

r? @emilio or @pcwalton

CC @paulrouget: This fixes a bug in the browser.html URL bar auto-completion.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10347)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 2, 2016
@jdm
Copy link
Member

jdm commented Apr 2, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 776aae6 with merge 0489280...

bors-servo pushed a commit that referenced this pull request Apr 2, 2016
Auto merge of #10347 - mbrubeck:incremental-selection, r=pcwalton
0489280 
Fix incremental reflow of text selection changes

r? @emilio or @pcwalton

CC @paulrouget: This fixes a bug in the browser.html URL bar auto-completion.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10347)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 2, 2016
@bors-servo bors-servo mentioned this pull request Apr 2, 2016
Merged
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

@bors-servo bors-servo merged commit 776aae6 into servo:master Apr 2, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 2, 2016
@mbrubeck mbrubeck deleted the incremental-selection branch May 17, 2016 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mbrubeck @highfive @pcwalton @jdm @paulrouget @bors-servo @emilio