Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanup. #10516

Merged
merged 4 commits into from
Apr 11, 2016
Merged

Various cleanup. #10516

merged 4 commits into from
Apr 11, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Apr 11, 2016

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/node.rs, components/script/dom/bindings/js.rs, components/script/dom/xmldocument.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 11, 2016
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@nox
Copy link
Contributor

nox commented Apr 11, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 3f95e4c has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 11, 2016
@nox nox assigned nox and unassigned glennw Apr 11, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 3f95e4c with merge 5adf362...

bors-servo pushed a commit that referenced this pull request Apr 11, 2016
Auto merge of #10516 - Ms2ger:cleanup, r=nox
5adf362 
Various cleanup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10516)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 3f95e4c into servo:master Apr 11, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 11, 2016
@Ms2ger Ms2ger deleted the cleanup branch April 19, 2016 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ms2ger @highfive @nox @bors-servo @glennw